New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 bugs in current rev. #76

Closed
bluenlive opened this Issue Oct 7, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@bluenlive

bluenlive commented Oct 7, 2018

Hi, first of all thank you for your great work, always.

Current revision has 2 big bugs.

  1. ANSI Art scheme doesn't work correctly.
    You can check it with attatched nfo file.

  2. When saving ini, font infos are not saved. Custom Colors, Default Text, etc.
    You can check it after removing notepad2.ini, press F7.

Check them please.

HiDt.zip

zufuliu added a commit that referenced this issue Oct 8, 2018

@zufuliu

This comment has been minimized.

Owner

zufuliu commented Oct 8, 2018

second bug is by design:
Settings with built-in default value will not kept in ini file, commit 675e86f and 91afe63.

@bluenlive

This comment has been minimized.

bluenlive commented Oct 8, 2018

Thank you.

BTW, after changing default font(Alt-F12), that info is not saved.
Could you check it once again?

@zufuliu

This comment has been minimized.

Owner

zufuliu commented Oct 8, 2018

@bluenlive Can you also test commit 04e5a10 (Treat CJK Ideographs and letters as a distinct Unicode category) introduced broken undesired behavior:
click the first line

Korean한글
https://en.wikipedia.org/wiki/Hangul

Korean and 한글 does NOT selected as a whole like before (or in Windows Notepad and edit box in Firefox).

@bluenlive

This comment has been minimized.

bluenlive commented Oct 8, 2018

Great! Both of the patches work well! Thank you!
And, 04e5a10 works as expected in Korean environment!
Great also!

Thank you again!!!

notepad1

notepad2

@bluenlive bluenlive closed this Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment