Skip to content

tools: Call pip from a sub-process instead of importing it #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timabbott merged 1 commit into from
Apr 16, 2018
Merged

tools: Call pip from a sub-process instead of importing it #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions zulip_bots/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import os
import sys
import glob
import pip
import subprocess
if False:
from typing import Any, Dict, Optional

Expand Down Expand Up @@ -105,4 +105,5 @@ def check_dependency_manually(module_name, version=None):
bot_paths = filter(lambda d: os.path.isdir(d), bots_subdirs)
for bot_path in bot_paths:
req_path = os.path.join(bot_path, 'requirements.txt')
rcode = pip.main(['install', '-r', req_path, '--quiet'])
if os.path.exists(req_path):
subprocess.check_call([sys.executable, '-m', 'pip', 'install', '-r', req_path, '--quiet'])