Added Clickable Links to narrow for user! #100

kunall17 · 2016-07-20T20:40:20Z

Fixes #39

smarx · 2016-07-20T20:40:21Z

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

niftynei · 2016-07-28T19:33:16Z

@kunall17 when I tap on a link, I get the following crash:

07-28 15:32:07.130 17641 17641 E AndroidRuntime: FATAL EXCEPTION: main
07-28 15:32:07.130 17641 17641 E AndroidRuntime: Process: com.zulip.android.dev, PID: 17641
07-28 15:32:07.130 17641 17641 E AndroidRuntime: java.lang.ClassCastException: android.support.v7.widget.TintContextWrapper cannot be cast to com.zulip.android.activities.ZulipActivity
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.zulip.android.util.ProfileSpan.onClick(ProfileSpan.java:43)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.text.method.LinkMovementMethod.onTouchEvent(LinkMovementMethod.java:217)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.widget.TextView.onTouchEvent(TextView.java:8325)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.View.dispatchTouchEvent(View.java:9300)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.android.internal.policy.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:2403)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1737)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.app.Activity.dispatchTouchEvent(Activity.java:2771)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.support.v7.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:63)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.support.v7.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:63)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.android.internal.policy.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:2364)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.View.dispatchPointerEvent(View.java:9520)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:4238)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:4104)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3650)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3703)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3669)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:3795)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3677)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:3852)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3650)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3703)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3669)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3677)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3650)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:5932)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.vi

niftynei · 2016-07-28T19:36:18Z

This looks good to me Kunal, other than the crash.

kunall17 · 2016-08-01T11:06:33Z

@niftynei updated..:)

kunall17 · 2016-08-11T06:07:23Z

@niftynei updated this branch as well!

niftynei · 2016-08-12T19:49:17Z

Two issues with this:

I click on @kunall17 , only a blank page shows. It works correctly for other users with no messages and with messages.
Pushing the back button doesn't take me back to the message that I clicked from, but resets it all the way back to the default ZulipActivity view. I'd expect to return to the place that I clicked into the user messages from. This is a blocker to getting this merged.

kunall17 · 2016-08-17T10:16:44Z

@nitfynei f8ca6c3 commit fixes first issue (when you clicked the link the toolbar was hidden, therefore a blank page would appear) now this commit makes the toolbar appear whenever narrowing is done!

second issue will be fixed in another PR which will take back to previous location after narrowing!

niftynei · 2016-08-22T19:43:29Z

opened issue #146 for the losing your place on back issue.

niftynei · 2016-08-22T19:49:18Z

@kunall17 I still get a blank screen. Tested by tapping on your user name :)

niftynei · 2016-08-22T19:50:47Z

The functionality that was asked for in #39 was to add the @ button, like on the web app:

This is different from the functionality in this PR -- the @-messages button narrows only to messages where you, the user, have been mentioned! 😆 I should have noticed this discrepancy sooner!

kunall17 · 2016-08-23T04:56:56Z

@niftynei I thought in the issue you were talking about the clickable links!
Anyways this was also needed, fixed the issue!

kunall17 · 2016-08-26T15:09:52Z

Updated this branch!
Any blocker for this branch?

niftynei · 2016-09-10T04:40:05Z

Merged!!!!! great piece of work @kunall17 🔨 🔨

kunall17 force-pushed the patch-15 branch from 00fe93c to 6812700 Compare July 20, 2016 21:04

kunall17 force-pushed the patch-15 branch from 6812700 to 1340b61 Compare August 1, 2016 11:05

kunall17 force-pushed the patch-15 branch from 1340b61 to 682794c Compare August 1, 2016 11:07

kunall17 force-pushed the patch-15 branch from 682794c to 7f404ae Compare August 11, 2016 06:06

kunall17 force-pushed the patch-15 branch from 7f404ae to f8ca6c3 Compare August 17, 2016 10:11

kunall17 force-pushed the patch-15 branch from b5e70c3 to d51a507 Compare August 23, 2016 04:52

kunall17 added 5 commits August 26, 2016 20:34

Initialize user tag text color

4ec2f49

Get All users from the database

d3a29ca

Implement ClickableSpan for user mentions

8d4e278

Always show AppBarLayout onNarrow

08ec3ab

Show another color if the user is mentioned

be45398

kunall17 force-pushed the patch-15 branch from d51a507 to be45398 Compare August 26, 2016 15:09

niftynei closed this Sep 10, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Clickable Links to narrow for user! #100

Added Clickable Links to narrow for user! #100

kunall17 commented Jul 20, 2016

smarx commented Jul 20, 2016

niftynei commented Jul 28, 2016

niftynei commented Jul 28, 2016

kunall17 commented Aug 1, 2016

kunall17 commented Aug 11, 2016

niftynei commented Aug 12, 2016

kunall17 commented Aug 17, 2016

niftynei commented Aug 22, 2016

niftynei commented Aug 22, 2016

niftynei commented Aug 22, 2016 •

edited

kunall17 commented Aug 23, 2016

kunall17 commented Aug 26, 2016

niftynei commented Sep 10, 2016

Added Clickable Links to narrow for user! #100

Added Clickable Links to narrow for user! #100

Conversation

kunall17 commented Jul 20, 2016

smarx commented Jul 20, 2016

niftynei commented Jul 28, 2016

niftynei commented Jul 28, 2016

kunall17 commented Aug 1, 2016

kunall17 commented Aug 11, 2016

niftynei commented Aug 12, 2016

kunall17 commented Aug 17, 2016

niftynei commented Aug 22, 2016

niftynei commented Aug 22, 2016

niftynei commented Aug 22, 2016 • edited

kunall17 commented Aug 23, 2016

kunall17 commented Aug 26, 2016

niftynei commented Sep 10, 2016

niftynei commented Aug 22, 2016 •

edited