New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Clickable Links to narrow for user! #100

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@kunall17
Collaborator

kunall17 commented Jul 20, 2016

Fixes #39

device-2016-07-21-020805

@smarx

This comment has been minimized.

smarx commented Jul 20, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@niftynei

This comment has been minimized.

Contributor

niftynei commented Jul 28, 2016

@kunall17 when I tap on a link, I get the following crash:

07-28 15:32:07.130 17641 17641 E AndroidRuntime: FATAL EXCEPTION: main
07-28 15:32:07.130 17641 17641 E AndroidRuntime: Process: com.zulip.android.dev, PID: 17641
07-28 15:32:07.130 17641 17641 E AndroidRuntime: java.lang.ClassCastException: android.support.v7.widget.TintContextWrapper cannot be cast to com.zulip.android.activities.ZulipActivity
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.zulip.android.util.ProfileSpan.onClick(ProfileSpan.java:43)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.text.method.LinkMovementMethod.onTouchEvent(LinkMovementMethod.java:217)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.widget.TextView.onTouchEvent(TextView.java:8325)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.View.dispatchTouchEvent(View.java:9300)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2553)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2254)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.android.internal.policy.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:2403)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1737)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.app.Activity.dispatchTouchEvent(Activity.java:2771)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.support.v7.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:63)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.support.v7.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:63)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at com.android.internal.policy.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:2364)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.View.dispatchPointerEvent(View.java:9520)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:4238)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:4104)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3650)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3703)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3669)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:3795)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3677)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:3852)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3650)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3703)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3669)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3677)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3650)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:5932)
07-28 15:32:07.130 17641 17641 E AndroidRuntime:    at android.vi
@niftynei

This comment has been minimized.

Contributor

niftynei commented Jul 28, 2016

This looks good to me Kunal, other than the crash.

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 1, 2016

@niftynei updated..:)

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 11, 2016

@niftynei updated this branch as well!

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 12, 2016

Two issues with this:

  1. I click on @kunall17 , only a blank page shows. It works correctly for other users with no messages and with messages.
  2. Pushing the back button doesn't take me back to the message that I clicked from, but resets it all the way back to the default ZulipActivity view. I'd expect to return to the place that I clicked into the user messages from. This is a blocker to getting this merged.
@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 17, 2016

@nitfynei f8ca6c3 commit fixes first issue (when you clicked the link the toolbar was hidden, therefore a blank page would appear) now this commit makes the toolbar appear whenever narrowing is done!

second issue will be fixed in another PR which will take back to previous location after narrowing!

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 22, 2016

opened issue #146 for the losing your place on back issue.

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 22, 2016

@kunall17 I still get a blank screen. Tested by tapping on your user name :)

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 22, 2016

The functionality that was asked for in #39 was to add the @ button, like on the web app:

image

This is different from the functionality in this PR -- the @-messages button narrows only to messages where you, the user, have been mentioned! 😆 I should have noticed this discrepancy sooner!

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 23, 2016

@niftynei I thought in the issue you were talking about the clickable links!
Anyways this was also needed, fixed the issue!

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 26, 2016

Updated this branch!
Any blocker for this branch?

@niftynei

This comment has been minimized.

Contributor

niftynei commented Sep 10, 2016

Merged!!!!! great piece of work @kunall17 🔨 🔨

@niftynei niftynei closed this Sep 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment