New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Client ID for registering GCM to that client #114

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kunall17
Collaborator

kunall17 commented Aug 5, 2016

As in #112 (comment) This now fetches Google client ID and uses that one to register a GCM client ID

@smarx

This comment has been minimized.

smarx commented Aug 5, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17 kunall17 referenced this pull request Aug 6, 2016

Closed

Notification support #112

@@ -237,8 +239,7 @@ protected void onCreate(Bundle savedInstanceState) {
return;
}
this.logged_in = true;
notifications = new Notifications(this);
notifications.register();
registerGCM();

This comment has been minimized.

@niftynei

niftynei Aug 8, 2016

Contributor

Needs to 'unregister' GCM after logout, including delete the saved google_client_id preference .

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 8, 2016

looks pretty good, see comments in line. In my test I didn't receive any notifications when I was pinged.

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 12, 2016

Superceded by #123

@niftynei niftynei closed this Aug 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment