New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create blank drawable if no emoji present #119

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kunall17
Collaborator

kunall17 commented Aug 12, 2016

I encountered a bug while logging into zulip.tabbott.net there was a emoji which is not in our android emoji's folder therefore it gave an error and the recyclerView wasn't able to render on the screen, I'm updating my dev server to get the new emoji's and post more emoji's here!
So this would render no emoji at that place which is better than nothing!

@smarx

This comment has been minimized.

smarx commented Aug 12, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 16, 2016

sounds good to me @kunall17 !

do you have an idea what it would take to get custom emoji onto the app?

@niftynei niftynei closed this Aug 16, 2016

@timabbott

This comment has been minimized.

Member

timabbott commented Aug 16, 2016

When you specify custom emoji, do you mean realm-specific emoji?

GET realm/emoji will fetch the emoji data from the server.

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 16, 2016

@timabbott yep exactly. issue #13 is already open for this. :)

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 20, 2016

@timabbott I recently migrated from fedora to windows because of some weird kernel errors!
In windows I haven't been able to dump the emoji's, I haven't tried anything more than python emoji_dump.py' inzulip/tools/setup/emoji_dump`

Dumping "NotoColorEmoji.ttf" to "/srv/zulip/tools/setup/emoji_dump/../../../var/emoji_dump/N                                                                                                    otoColorEmoji.ttx"...
Dumping 'GlyphOrder' table...  (10:44:58)
Reading 'post' table from disk  (10:44:58)
Decompiling 'post' table  (10:44:58)
Reading 'maxp' table from disk  (10:44:58)
Decompiling 'maxp' table  (10:44:58)
Reading 'cmap' table from disk  (10:44:58)
Decompiling 'cmap' table  (10:44:58)
Reading 'head' table from disk  (10:44:58)
Decompiling 'head' table  (10:44:58)
Dumping 'head' table...  (10:44:58)
Reading 'hhea' table from disk  (10:44:58)
Decompiling 'hhea' table  (10:44:58)
Dumping 'hhea' table...  (10:44:58)
Dumping 'maxp' table...  (10:44:58)
Reading 'OS/2' table from disk  (10:44:58)
Decompiling 'OS/2' table  (10:44:58)
Dumping 'OS/2' table...  (10:44:58)
Reading 'hmtx' table from disk  (10:44:58)
Decompiling 'hmtx' table  (10:44:58)
Dumping 'hmtx' table...  (10:44:58)
Dumping 'cmap' table...  (10:44:58)
Reading 'name' table from disk  (10:44:58)
Decompiling 'name' table  (10:44:58)
Dumping 'name' table...  (10:44:58)
Dumping 'post' table...  (10:44:58)
Reading 'CBDT' table from disk  (10:44:58)
Decompiling 'CBDT' table  (10:44:58)
Reading 'CBLC' table from disk  (10:44:58)
Decompiling 'CBLC' table  (10:44:58)
Dumping 'CBDT' table...  (10:44:58)
Dumping 'CBLC' table...  (10:45:05)
Reading 'GSUB' table from disk  (10:45:05)
Decompiling 'GSUB' table  (10:45:05)
Dumping 'GSUB' table...  (10:45:06)
Done dumping TTX  (10:45:06)
Traceback (most recent call last):
  File "emoji_dump.py", line 123, in <module>
    main()
  File "emoji_dump.py", line 114, in main
    'out/{}.png'.format(name)
OSError: [Errno 71] Protocol error

I always get this error!
I had to dump the new emoticons of the server in the android project!

@timabbott

This comment has been minimized.

Member

timabbott commented Aug 22, 2016

I think the issue is a Vagrant/Virtualbox/Windows compatibility issue; the reproducer is I think trying to make a symlink. See hashicorp/vagrant#6024; I think it may be you need to upgrade virtualbox to fix this problem?

@timabbott

This comment has been minimized.

Member

timabbott commented Aug 22, 2016

Uploaded the emoji in a tarball (see attached).

emoji.tar.gz

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 23, 2016

@timabbott thankyou so much for the archive! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment