Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a Widget for reading messages #129

Closed
wants to merge 12 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@kunall17
Copy link
Collaborator

kunall17 commented Aug 16, 2016

Currently this widget is read only
Messages can be filtered by showing only today's, yesterday's or a week before messages!
And the update frequency can be changed!

Recording:
recording
Screenshot:
device-2016-08-16-175418

@smarx

This comment has been minimized.

Copy link

smarx commented Aug 16, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17 kunall17 force-pushed the kunall17:patch-29-widget branch from 2fded8a to 2964cc5 Aug 17, 2016

@kunall17 kunall17 force-pushed the kunall17:patch-29-widget branch from 2964cc5 to a678c62 Aug 22, 2016

@@ -56,9 +60,20 @@ public AsyncGetEvents(ZulipActivity humbugActivity) {
request = new HTTPRequest(app);
}

public AsyncGetEvents(ZulipApp zulipApp, int INTERVAL) {

This comment has been minimized.

@niftynei

niftynei Aug 22, 2016

Contributor

the INTERVAL variable should be lower case. ie interval

@@ -41,6 +43,8 @@
private static final String POINTER = "pointer";
private ZulipActivity activity;
private ZulipApp app;
private static int INTERVAL = 1000;

This comment has been minimized.

@niftynei

niftynei Aug 22, 2016

Contributor

since this isn't a constant, it should be camel-cased, ie sInterval

<string name="update_interval">Update interval</string>
<string name="default_summary_from">Today</string>
<string name="widget_title_from">Show messages since</string>
<string name="no_login_error_widget">First login to zulip app.</string>

This comment has been minimized.

@niftynei

niftynei Aug 22, 2016

Contributor

Zulip should be capitalized! 😄

@niftynei

This comment has been minimized.

Copy link
Contributor

niftynei commented Aug 22, 2016

lgtm @kunall17 ! I pointed out a few things to change, but otherwise seems smashing!

@kunall17 kunall17 force-pushed the kunall17:patch-29-widget branch from a678c62 to 87e008e Aug 23, 2016

@kunall17

This comment has been minimized.

Copy link
Collaborator Author

kunall17 commented Aug 23, 2016

Rebased branch + fixed the comments

@niftynei

This comment has been minimized.

Copy link
Contributor

niftynei commented Aug 23, 2016

Great, merged! :)

@niftynei niftynei closed this Aug 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.