New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #132 Show Title and name in header if narrowed to self PM's #140

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kunall17
Collaborator

kunall17 commented Aug 18, 2016

I have also checked this function https://github.com/kunall17/zulip-android/blob/43fef77636256b2f7ec51d560f0c7f6aa35be88c/app/src/main/java/com/zulip/android/models/Message.java#L241 which is being edited in this PR, is only used in this binding the Recipent Bar.

@smarx

This comment has been minimized.

smarx commented Aug 18, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@timabbott

This comment has been minimized.

Member

timabbott commented Aug 19, 2016

The bug I reported only impacted messages you sent directly to yourself; this patch seems to change the rendering of group conversations between you and other people in a way that I found confusing:

image

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 20, 2016

Fixed logged in as Iago in the screenshot!
device-2016-08-20-154726

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 22, 2016

lgtm. fixes issue shown in @timabbott 's screenshots.

@niftynei niftynei closed this Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment