New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented swipe to remove chatBox #143

Merged
merged 4 commits into from Aug 22, 2016

Conversation

Projects
None yet
3 participants
@kunall17
Collaborator

kunall17 commented Aug 22, 2016

record

@smarx

This comment has been minimized.

smarx commented Aug 22, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 22, 2016

nice! works well afaict. it's not the most discoverable functionality, but it definitely serves it's purpose. 👌

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Aug 22, 2016

Agreed, but this will be needed as after narrowing it will focus the message edit text and then the chat box won't go automatically on scrolling, so then hopefully user will try to swipe to remove chatBox

@niftynei niftynei merged commit 526f349 into zulip:master Aug 22, 2016

@niftynei

This comment has been minimized.

Contributor

niftynei commented Aug 22, 2016

💯 🌋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment