New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated To Gradle #25

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@kunall17
Collaborator

kunall17 commented Mar 1, 2016

After all these commits the project is migrated to gradle, having targetSDKVersion 23, and running!
Upgraded Crashlytics to Fabric Crashlytics!

Commit Fixed Project (d2c37b8) deals with a

  • bug due to Search View
  • Now using GoogleApiClient.OnConnectionFailedListener
  • And rest mostly are the formatting!
@smarx

This comment has been minimized.

smarx commented Mar 1, 2016

Automated message from Dropbox CLA bot

@kunall17, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here and update the thread so we can consider merging your code.

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Mar 1, 2016

@lfaraone lfaraone referenced this pull request Mar 3, 2016

Closed

Switch to gradle builds #2

@lfaraone

This comment has been minimized.

Member

lfaraone commented Mar 13, 2016

Hi @kunall17 , thanks for the pull request. I've since moved the project to Gradle and pushed master. We aren't able to upgrade to Fabric Crashlytics just yet, so I've kept the embedded crashlytics.jar.

Right now, this PR combines several changes into one (see e.g. d2c37b8); it would be great if you could rebase off latest master and split out your commits per [https://zulip.readthedocs.org/en/latest/code-style.html#version-control Code Style: Version Control].

@timabbott

This comment has been minimized.

Member

timabbott commented Mar 14, 2016

@lfaraone I guess we should add a link to README.md for this project pointing to the overall Zulip version control docs?

@lfaraone

This comment has been minimized.

Member

lfaraone commented Mar 14, 2016

Will do.

On Sun, 13 Mar 2016, 17:56 Tim Abbott, notifications@github.com wrote:

@lfaraone https://github.com/lfaraone I guess we should add a link to
README.md for this project pointing to the overall Zulip version control
docs?


Reply to this email directly or view it on GitHub
#25 (comment).

@kunall17 kunall17 referenced this pull request Mar 14, 2016

Closed

Added Material design #27

@lfaraone

This comment has been minimized.

Member

lfaraone commented Mar 29, 2016

future changes in #27

@lfaraone lfaraone closed this Mar 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment