New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Material design #27

Closed
wants to merge 28 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@kunall17
Collaborator

kunall17 commented Mar 14, 2016

Hello @lfaraone While rebasing I was facing many conflicts so I created a new branch in my fork and split the commits (same commits as in PR #25 )

@smarx

This comment has been minimized.

smarx commented Mar 14, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@lfaraone lfaraone referenced this pull request Mar 29, 2016

Closed

Migrated To Gradle #25

@niftynei niftynei added the enhancement label Apr 1, 2016

@niftynei

This comment has been minimized.

Contributor

niftynei commented Apr 1, 2016

I ran this to see what the changes looked like. @kunall17 the text isn't legible on my phone (Nexus 5X running 6.0.1). Is it visible on yours?

The actionbar color is vastly different from the original. Not sure if this is a new color we're going for? pinging @lfaraone for his input.

Finally, the buttons for "compose private message" and "compose message to stream" are missing (pushed into the overflow menu).

screenshot_20160401-121042
screenshot_20160401-121053
screenshot_20160401-121056
screenshot_20160401-121107
screenshot_20160401-121112
screenshot_20160401-121124
screenshot_20160401-121131

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Apr 1, 2016

Pushed some commits now

Screenshot
screenshot_2016-04-02-03-31-43

@kunall17

This comment has been minimized.

Collaborator

kunall17 commented Apr 1, 2016

Pushed one more commit which now changes the colors of the toolbar and status bar

screenshot_2016-04-02-03-59-53

@niftynei

This comment has been minimized.

Contributor

niftynei commented Apr 12, 2016

super ceded by #35 . If there's changes in this PR that you'd like to include in the updated app, please re-submit a new PR.

@niftynei niftynei closed this Apr 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment