New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the previous chatBox espresso test's #79

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@kunall17
Collaborator

kunall17 commented Jun 28, 2016

015d486: Fixes wrong hint shown in the chatBox

@smarx

This comment has been minimized.

smarx commented Jun 28, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@@ -42,7 +42,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
android:dropDownWidth="fill_parent"
android:hint="@string/stream_txt"
android:hint="@string/subject"

This comment has been minimized.

@niftynei

niftynei Jul 7, 2016

Contributor

Is this related to fixing the espresso tests?

This comment has been minimized.

@kunall17

kunall17 Jul 8, 2016

Collaborator

No, it was just a small fixup so I posted this commit here!

This comment has been minimized.

@niftynei

niftynei Jul 8, 2016

Contributor

Ah ok, thanks!

@niftynei

This comment has been minimized.

Contributor

niftynei commented Jul 11, 2016

These compile & run but none of them pass. I think the problem is that I'm logged in when they start. Can you write up some docs on what state your app should be in when these start?

Functional tests are flakey, I'm a bigger proponent of unit tests for Android stuff.

@niftynei

This comment has been minimized.

Contributor

niftynei commented Jul 11, 2016

This has been merged!

@niftynei niftynei closed this Jul 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment