Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppCompatActivity and Toolbar AppCompatChanges #83

Merged
merged 7 commits into from Jul 19, 2016

Conversation

Projects
None yet
3 participants
@kunall17
Copy link
Collaborator

kunall17 commented Jul 11, 2016

This changes the current old Activity to AppCompatActivity and using the toolbar.
Also uses the new DayNight AppCompat theme therefore in another PR will add a feature to switch between day and night themes:

API 22 API 16
@smarx

This comment has been minimized.

Copy link

smarx commented Jul 11, 2016

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

compile "com.android.support:recyclerview-v7:23.0.1"
compile 'com.android.support:appcompat-v7:24.0.0'
compile 'com.android.support:design:24.0.0'
compile 'com.android.support:recyclerview-v7:24.0.0'

This comment has been minimized.

@niftynei

niftynei Jul 18, 2016

Contributor

🎉

@@ -53,6 +55,10 @@ protected void onCreate(Bundle savedInstanceState) {

setContentView(R.layout.login);

Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
toolbar.setTitle("Login");

This comment has been minimized.

@niftynei

niftynei Jul 18, 2016

Contributor

Human readable strings belong in strings.xml.

setSupportActionBar(toolbar);
getSupportActionBar().setDisplayHomeAsUpEnabled(true);
getSupportActionBar().setHomeButtonEnabled(true);
getSupportActionBar().setTitle("Zulip");

This comment has been minimized.

@niftynei

niftynei Jul 18, 2016

Contributor

Human readable strings belong in strings.xml.

@niftynei

This comment has been minimized.

Copy link
Contributor

niftynei commented Jul 19, 2016

@kunall17 this looks pretty good! The Welcome to Zulip text on my screen is too small (see screenshot). Also the checkbox & textview fields have a purplish tint to them. Can we make them go back to black?

screenshot_20160718-195029

@kunall17

This comment has been minimized.

Copy link
Collaborator Author

kunall17 commented Jul 19, 2016

@niftynei yeah for the accent color I changed it to purple color as in the zulip web-UI logo background color!
what should this be?

@niftynei

This comment has been minimized.

Copy link
Contributor

niftynei commented Jul 19, 2016

@kunall17 cool, it's a nice color. I guess my biggest problem with it is that when you check and uncheck the Use Zulip.com box, it changes back to black.

In the future it'd be nicer to have small changes like this (changing the color of the accents) in separate PRs, with the changes explicitly labeled. Having them all together makes it harder to figure out what's intentional and what's incidental.

@kunall17 kunall17 force-pushed the kunall17:patch-9-material branch from d89d95c to 2f730a3 Jul 19, 2016

@kunall17

This comment has been minimized.

Copy link
Collaborator Author

kunall17 commented Jul 19, 2016

@niftynei updated the PR :)

@niftynei niftynei merged commit 2f730a3 into zulip:master Jul 19, 2016

@niftynei

This comment has been minimized.

Copy link
Contributor

niftynei commented Jul 19, 2016

merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.