Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse topic permalinks #684

Closed
gnprice opened this issue May 16, 2024 · 1 comment · Fixed by #729
Closed

Parse topic permalinks #684

gnprice opened this issue May 16, 2024 · 1 comment · Fixed by #729
Assignees
Labels
a-api Implementing specific parts of the Zulip server API server-9 Things new in Zulip Server 9.0

Comments

@gnprice
Copy link
Member

gnprice commented May 16, 2024

When parsing an internal link, we should handle the upcoming "topic permalink" feature:

In the current draft, these look like /with/NNNN, with a message ID.

Currently the app doesn't interpret /near/ links at all (that's #82 and #683). So we should handle these new /with/ links the same way for now — accept them and ignore them.

In the future when we implement #683, these new links should be included in that behavior, but unlike /near/ links they won't have the behavior of #82. (They'll have the behavior #80 instead, like other narrow links.)

@gnprice gnprice added a-api Implementing specific parts of the Zulip server API server-9 Things new in Zulip Server 9.0 labels May 16, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 16, 2024
@gnprice gnprice assigned sm-sayedi and unassigned sm-sayedi May 31, 2024
@gnprice
Copy link
Member Author

gnprice commented May 31, 2024

(Assigned and unassigned because I was looking at the wrong column in the project board; what I meant to do was to set the "owner", to place it in Sayed's section of the board. Did that now, and @sm-sayedi please go ahead and self-assign the issue whenever you start working on it.)

@sm-sayedi sm-sayedi self-assigned this Jun 11, 2024
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
These links (`/with/NNNN`) are just accepted and ignored in this PR,
they will be interpreted in zulip#683.

Fixes: zulip#684
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
These links (`/with/NNNN`) are just accepted and ignored in this PR,
they will be interpreted in zulip#683.

Fixes: zulip#684
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Jun 11, 2024
These links (`/with/NNNN`) are just accepted and ignored in this PR,
they will be interpreted in zulip#683.

Fixes: zulip#684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API server-9 Things new in Zulip Server 9.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants