-
-
Notifications
You must be signed in to change notification settings - Fork 643
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SmartUrlInput: Remove not-so-helpful "smart"ness
And just use an ordinary controlled TextInput, always stretched to full width, and never just 1px. The major reason for this is to fix #5228 (can't paste org URL): native copy-paste is activated by long-pressing in the input element itself. But long-pressing is really hard when the element is only 1px wide! Include some placeholder text to help people have some idea of what to put here. Don't require or prefill with "https://"; instead, fill that in if no supported scheme is provided. ("Supported scheme" just means "http://" or "https://"; other schemes just don't make sense in this context.) See discussion at https://chat.zulip.org/#narrow/stream/48-mobile/topic/can't.20paste.20org.20URL/near/1327170 Fixes: #5228
- Loading branch information
1 parent
393dc26
commit aeeb835
Showing
4 changed files
with
20 additions
and
272 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.