Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let release and debug builds coexist on Android device #2705

Closed
gnprice opened this issue Jun 20, 2018 · 11 comments

Comments

@gnprice
Copy link
Member

commented Jun 20, 2018

For some kinds of debugging, it's helpful to install the debug build on your own device, where you may also have the release build installed from the Play Store.

(The same thing is true on iOS, but I think the mechanisms to do it will be different and I don't know the exact situation; so that's for a separate issue.)

Currently this isn't possible. The main obstacle is that we're using the same app ID for debug and release. Instead, we should build the app with a separate "application ID" when doing a debug (aka dev) build. There's upstream docs for this here:
https://developer.android.com/studio/build/application-id#change_the_application_id_for_build_variants

I think there may be another obstacle or two that come up. They should all be solvable with a bit of Gradle code, taking advantage of documentation and also Stack Overflow and other web search results.

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2018

Can I work on this issue?

@jainkuniya

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

Ya! sure go for it @prateek3255.

Let me know if you face any problem either here or on https://chat.zulip.org/#narrow/stream/243-mobile-team

Claim this issue by commenting @zulipbot claim on this.

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2018

Ok I will start working on it soon.

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2018

@zulipbot claim

@zulipbot

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

Hello @prateek3255!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2018

@jainkuniya So can I work on it or not?

@jainkuniya

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

@zulipbot label "help wanted"

@jainkuniya

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

@prateek3255 Now you can claim :)

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2018

@zulipbot claim

@zulipbot

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

Welcome to Zulip, @prateek3255! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-mobile/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Jun 29, 2018

@jainkuniya please review my PR #2743 for this issue.

jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Jul 1, 2018

jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Jul 2, 2018

android: Make release and debug app build coexist in the same phone.
Now when we run `react-native run-android` will install debug
build of the app. But it will try to launch the app with the
default package name (without any suffix), as it is launched by RN.
We need to tell RN to launch debug build which has suffix 'debug'.

So use `react-native run-android --appIdSuffix=debug`.

Fix:zulip#2705

jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Jul 12, 2018

android: Make release and debug app build coexist in the same phone.
Now when we run `react-native run-android` will install debug
build of the app. But it will try to launch the app with the
default package name (without any suffix), as it is launched by RN.
We need to tell RN to launch debug build which has suffix 'debug'.

So use `react-native run-android --appIdSuffix=debug`.

Fix:zulip#2705

jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Jul 25, 2018

android: Make release and debug app build coexist in the same phone.
Now when we run `react-native run-android` will install debug
build of the app. But it will try to launch the app with the
default package name (without any suffix), as it is launched by RN.
We need to tell RN to launch debug build which has suffix 'debug'.

So use `react-native run-android --appIdSuffix=debug`.

Fix:zulip#2705

gnprice added a commit that referenced this issue Jul 30, 2018

android: Use modified app icon for debug builds.
We're going to make it possible soon to install both debug and release
versions separately on the same device (#2705).  So to distinguish
them, it's best if they have different launcher app icons.

Debug app icon is same as release one with a red DEBUG label added.

@gnprice gnprice closed this in 2857d59 Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.