Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include debug build launcher app icon in release APK/package. #2898

Closed
jainkuniya opened this issue Aug 17, 2018 · 4 comments

Comments

@jainkuniya
Copy link
Member

commented Aug 17, 2018

Currently there is no logic which says, ic_debug_launcher is only used in debug build, so it is also present in release build. We can save few space (but very less). But for future this might be helpful, when we have more build based resources.

For reference:
https://stackoverflow.com/questions/33760518/android-gradle-have-both-debug-and-release-resources-in-different-flavors

@jainkuniya

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2018

@zulipbot label "good first issue"

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2018

@zulipbot claim

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Aug 23, 2018

I want to work on this issue.

@prateek3255

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2018

@jainkuniya can you review my PR #2916 for this issue.

jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Sep 18, 2018

android: Add debug and release resourse dir separatory.
Now in APK res will be added on the basis of build type. So if it is
release build then it will not contain res of debug build and vice
versa. Will affect the APK in a good manner, i.e reduce a bit.

Fix: zulip#2898

jainkuniya added a commit to jainkuniya/zulip-mobile that referenced this issue Sep 18, 2018

android: Create debug and release resourse dir separatory.
Now in APK res will be added on the basis of build type. So if it is
release build then it will not contain res of debug build and vice
versa. Will affect the APK in a good manner, i.e reduce a bit.

Fix: zulip#2898

@gnprice gnprice closed this in 6e4677f Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.