New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: NoSuchMethodError for builder.addAction #1088

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@kunall17
Contributor

kunall17 commented Aug 24, 2017

Fixes #1085

@zulipbot

This comment has been minimized.

Member

zulipbot commented Aug 24, 2017

Hello @kunall17, it seems like you have referenced an issue in your pull request, but you have not referenced that issue in your commit message(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with "Fixes #[issue number]”.

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51

Thank you for your contributions to Zulip!

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Aug 24, 2017

Cool.

@borisyankov borisyankov merged commit 8df2f23 into zulip:master Aug 24, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@zulipbot zulipbot removed the needs review label Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment