Always enable notifications + Fix them #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisyankov
force-pushed
the
always-enable-notifications
branch
from
1bad4ad
to
be20743
Compare
borisyankov
changed the title
Previously we did disable notifications on emulators. That is not only not needed but also counter-productive as we want to be able to test them on different device configurations. Removes the config flag `enableNotifications` completely and the check that uses this flag to enable/not enable the notifications.
Fixes zulip#3113. The native code inside `react-native-notifications` varied its behavior when reading the `gcm_id` value from the metadata. Because of this, in the emulator it was throwing a `MismatchSenderId` error. From an upstream issue thread, we take the solution of changing `android:value="your_sender_id\0"` to `android:value="your_sender_id\"`. This works on both an emulated and a physical device, despite the warning in the official documentation: // IMPORTANT: Leave the trailing \0 intact!!! While here, clean up a bit: extract this value to a string resource and refer to it by name.
gnprice
force-pushed
the
always-enable-notifications
branch
from
554d576
to
66e8675
Compare
|
Merged. Thanks @borisyankov for debugging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did disable notifications on emulators. That is not
only not needed but also counter-productive as we want to be able
to test them on different device configurations.
Removes the config flag
enableNotificationscompletely and thecheck that uses this flag to enable/not enable the notifications.
Also, fixes notifications not working in Android emulator!