New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reducers for receiving updates on subscriptions and muted topics #569

Merged
merged 2 commits into from May 11, 2017

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented May 9, 2017

No description provided.

@smarx

This comment has been minimized.

smarx commented May 9, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

case 'muted_topics':
return {
type: EVENT_MUTED_TOPICS,
muted_topics: event.muted_topics

This comment has been minimized.

@borisyankov

borisyankov May 9, 2017

Contributor

Here you can do either:

...events,

And achieve the same + if there are any other props they will be passed on...
or do

mutedTopics: event.muted_topics

since all the naming we custom create will be in js casing.

@zulipbot zulipbot added reviewed and removed needs review labels May 9, 2017

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented May 9, 2017

Looks good... except that you have to write some tests :)

@kunall17

This comment has been minimized.

Contributor

kunall17 commented May 10, 2017

Added test's, and updated the branch

@borisyankov borisyankov merged commit 969a145 into zulip:master May 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 58.523%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment