New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #683: Split users into users and presence #750

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented Jun 26, 2017

@borisyankov The presence is added when a user logs in (rather when the server sends this event type), and the whole user list is not added, when a person comes online the email is added to the presence state, Hence this adds new users as well which conflicts your previous way of doing this (That ignored the users)

The timestamp and the status is saved and the online status can be determined, currently the presence is not used anywhere (though it is passed in ConversationCard and one more component)

Needs more testing, though!

@smarx

This comment has been minimized.

smarx commented Jun 26, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17 kunall17 changed the title from [WIP] Fixes #683: Split users into users and presence to Fixes #683: Split users into users and presence Jun 28, 2017

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jun 28, 2017

Works well, up for a review!

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jun 28, 2017

TL; DR; LGTM; 🥇

@borisyankov borisyankov merged commit 37e04f6 into zulip:master Jun 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 58.882%
Details

@zulipbot zulipbot removed the needs review label Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment