New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace appium with detox #825

Merged
merged 2 commits into from Jul 10, 2017

Conversation

Projects
None yet
3 participants
@kunall17
Contributor

kunall17 commented Jul 7, 2017

This removes the appium used for UI test's and use https://github.com/wix/detox for the tests!
Few conclusions for detox:

  • Test's are not flaky but weird, as in some code situations same code doesn't work like in this commit
    This line await element(by.type('RCTTextField')).clearText(); works in one test but doesn't work in another test (And this is the first line of the test)
  • Matchers are not easy to write, For example to find some view to determine its unique selector you need to browse this kind of massive tree.
  • Small refractoring/changes in the UI/JSX of a component can break a test, unless we don't use ID's

For the infinite loop I have disabled the synchronisation when in the main screen component, as there were many other thread blocking processes going on.

@borisyankov borisyankov merged commit d0119ad into zulip:master Jul 10, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@zulipbot zulipbot removed the needs review label Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment