New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translated strings in message action sheet #829

Merged
merged 1 commit into from Oct 7, 2017

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented Jul 8, 2017

After this gets merged will convert the other local strings as well!

@smarx

This comment has been minimized.

smarx commented Jul 8, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 9, 2017

Updated

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 11, 2017

Not a fan of how it is implemented.
I would have preferred for everything to go through React Intl.
Give me few days, I'll research the topic more and give you a more thorough review and suggestions.

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 20, 2017

@borisyankov Updated the branch, with usage with react-intl!

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 28, 2017

@borisyankov Reminder for this one!

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Aug 9, 2017

@borisyankov Rebased and fix merge conflicts!

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Aug 14, 2017

@borisyankov Is there any blocker with this PR ?

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Oct 7, 2017

Sorry for the delay, had to research if this is the proper way to implement this.
I think it is good to merge, after the rebase ;)

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Oct 7, 2017

Updated!

@borisyankov borisyankov merged commit 352d69a into zulip:master Oct 7, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@zulipbot zulipbot removed the needs review label Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment