New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prettier for the project #850

Merged
merged 1 commit into from Jul 11, 2017

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented Jul 11, 2017

This would help in code situations like in

const { narrow, subscriptions, unreadPrivateMessagesCount, onPressStreams, onPressPeople, } = this.props;

and converting it to

    const {
      narrow,
      subscriptions,
      unreadPrivateMessagesCount,
      onPressStreams,
      onPressPeople,
    } = this.props;
@smarx

This comment has been minimized.

smarx commented Jul 11, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@@ -13,7 +13,7 @@
"android-min": "react-native run-android",
"android-max": "react-native run-android",
"android-release": "react-native run-android --configuration 'Release'",
"test:lint": "eslint src/",
"test:lint": "prettier src/events/eventToAction.js",

This comment has been minimized.

@borisyankov

borisyankov Jul 11, 2017

Contributor

Wuut?

This comment has been minimized.

@kunall17

kunall17 Jul 11, 2017

Contributor

Was just testing this, forget to remove this :)

@zulipbot zulipbot added reviewed and removed needs review labels Jul 11, 2017

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 11, 2017

👍 but see my comment.

@zulipbot zulipbot added needs review and removed reviewed labels Jul 11, 2017

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 11, 2017

Done, btw for the fixing part should i do it in another PR or commit?

@borisyankov borisyankov merged commit edcadf1 into zulip:master Jul 11, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@zulipbot zulipbot removed the needs review label Jul 11, 2017

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 11, 2017

Yes, I am not even too sure we want to do it in a commit right now. Since this will break a lot of the history of who did work on what. Maybe for awhile people will run prettier on files they worked on, which not ideal, is closer to the ideal case.

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 11, 2017

Hmm, true but this will now make the CI break, we must fix something for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment