New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle back pressed in android #898

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented Jul 19, 2017

  • Pops narrow on back pressed on android
@smarx

This comment has been minimized.

smarx commented Jul 19, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17 kunall17 changed the title from [WIP] Pop narrow on back pressed in android to [WIP] Handle back pressed in android Jul 19, 2017

@kunall17 kunall17 changed the title from [WIP] Handle back pressed in android to Handle back pressed in android Jul 19, 2017

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 19, 2017

We are not going to implement this manually.
React Navigation is what is meant to do the navigating. On each narrow, we will be pushing a new route, and then the back button will automatically work.

It is too early to implement though. Nash has to prototype and we have to decide on the exact behavior.

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 28, 2017

Implementing this the correct way is also simpler.
Have a look at MainScreenWithTabs.js (which is not yet used) and if you want work on adding it there via pushing a new route.

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 30, 2017

@borisyankov Hmm, i'll see already having a lot of things to work on! :)

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 30, 2017

Ok, I'll be finishing up the navigation-push approach. It is close to being done, and is way simpler than this...
Closing the PR then.

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Aug 14, 2017

@borisyankov I would say let's revive this PR for a temporary fix till we have the new navigation rework and fix for #906
And the app exits on back press feels annoying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment