New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Downgrade photoview dependency to 1.2.0 #899

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
6 participants
@kunall17
Contributor

kunall17 commented Jul 19, 2017

Not sure if other folks are getting this error

Bundling `index.android.js`  100.0(1/1), done.
error: bundling: UnableToResolveError: Unable to resolve module `react-native/Libraries/Components/View/ViewPropTypes` from `/Users/kunall17/Project/react/zulip-mobile/node_modules/react-native-photo-view/PhotoView.android.js`: Module does not exist in the module map or in these directories:
  /Users/kunall17/Project/react/zulip-mobile/node_modules/react-native/Libraries/Components/View
,   /Users/kunall17/node_modules/react-native/Libraries/Components/View

This might be related to https://github.com/facebook/react-native/issues/4968
To resolve try the following:
  1. Clear watchman watches: `watchman watch-del-all`.
  2. Delete the `node_modules` folder: `rm -rf node_modules && npm install`.
  3. Reset packager cache: `rm -fr $TMPDIR/react-*` or `npm start --reset-cache`.
    at p.catch.error (/Users/kunall17/Project/react/zulip-mobile/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:366:19)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:169:7)
Bundling `index.android.js`  83.6(620/678), failed.
@smarx

This comment has been minimized.

smarx commented Jul 19, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@jainkuniya

This comment has been minimized.

Member

jainkuniya commented Jul 19, 2017

I am too facing this problem 👍

@Sam1301

This comment has been minimized.

Member

Sam1301 commented Jul 19, 2017

Thanks for noticing this 👍 , seems to be a regression.

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 19, 2017

Don't forget to report these issues to the original library authors.

@borisyankov borisyankov merged commit 41541be into zulip:master Jul 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 42.404%
Details

@zulipbot zulipbot removed the needs review label Jul 19, 2017

@Sam1301

This comment has been minimized.

Member

Sam1301 commented Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment