New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detox smoke test's in the travis CI #915

Merged
merged 16 commits into from Aug 14, 2017

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented Jul 21, 2017

The ios build run's fine on Xcode but fails in command line xcodebuild -project ios/ZulipMobile.xcodeproj -scheme ZulipMobile -configuration Release -sdk iphonesimulator -derivedDataPath ios/build

** BUILD FAILED **
The following build commands failed:
	CompileC build/Build/Intermediates.noindex/ZulipMobile.build/Release-iphonesimulator/ZulipMobile.build/Objects-normal/x86_64/AppDelegate.o ZulipMobile/AppDelegate.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
child_process.js:634
    throw err;
    ^
Error: Command failed: xcodebuild -project ios/ZulipMobile.xcodeproj -scheme ZulipMobile -configuration Release -sdk iphonesimulator -derivedDataPath ios/build
    at checkExecSyncError (child_process.js:591:13)
    at Object.execSync (child_process.js:631:13)
    at Object.<anonymous> (/Users/travis/build/kunall17/AutoTools/node_modules/detox/local-cli/detox-build.js:26:6)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:158:16)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Any info how to resolve this error?

@smarx

This comment has been minimized.

smarx commented Jul 21, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 21, 2017

You might want to try ZulipMobile.xcworkspace and maybe pod install (not sure if relevant)

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 21, 2017

@borisyankov Not working with these!

This was referenced Jul 26, 2017

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Aug 5, 2017

After a lot of work and trials the CI is hooked up with the basic detox UI test's!
Next step would be initiate the server and then use the server to execute more tests. :) 🎉

@kunall17 kunall17 changed the title from [WIP] Added detox smoke test's in the travis CI to Added detox smoke test's in the travis CI Aug 5, 2017

@zulipbot

This comment has been minimized.

Member

zulipbot commented Aug 5, 2017

Heads up @kunall17, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

1 similar comment
@zulipbot

This comment has been minimized.

Member

zulipbot commented Aug 7, 2017

Heads up @kunall17, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Aug 12, 2017

@borisyankov fixed this, LGTM
After this I'll write more test cases!

@zulipbot

This comment has been minimized.

Member

zulipbot commented Aug 13, 2017

Heads up @kunall17, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Aug 14, 2017

Do the Travis tests pass consistently? What are the risks if we merge this?
@Sam1301 have a look at this PR too (and comment). We will all be writing tests next.

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Aug 14, 2017

Let's see, I have rebased!

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Aug 14, 2017

@borisyankov the build passed after rebasing, so it would be stable if the detox test's passes locally!

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Aug 14, 2017

Merging it then. 🌮

@borisyankov borisyankov merged commit 9b612a9 into zulip:master Aug 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 46.787%
Details

@zulipbot zulipbot removed the needs review label Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment