New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unread selectors and fix eslint error #928

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
4 participants
@kunall17
Contributor

kunall17 commented Jul 25, 2017

No description provided.

@smarx

This comment has been minimized.

smarx commented Jul 25, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17 kunall17 changed the title from Fix unread selectors to Fix unread selectors and fix eslint error Jul 25, 2017

@borisyankov

This comment has been minimized.

Contributor

borisyankov commented Jul 25, 2017

Currently, the API actually returns 'mentioned'.
I have addressed both cases in a PR I am merging today.

@kunall17

This comment has been minimized.

Contributor

kunall17 commented Jul 25, 2017

I changed it to mentioned, merge this if your PR takes more time.
Main concern is the master is broken!

@borisyankov borisyankov merged commit 7932f44 into zulip:master Jul 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 42.823%
Details

@zulipbot zulipbot removed the needs review label Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment