Apply 'user-mention-me' styles to self mentions span. #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jainkuniya
commented
Jul 27, 2017
jainkuniya
commented
borisyankov
suggested changes
Jul 28, 2017
src/html/tags/HtmlTagSpan.js
Outdated
| props: { | ||
| style?: StyleObj, | ||
| actions?: Actions, | ||
| cascadingStyle?: StyleObj, | ||
| attribs?: Object, | ||
| ownEmail: string, |
There was a problem hiding this comment.
This is conceptually incorrect.
Our HtmlTagSpan should be aware only of general 'span' related stuff.
If we can not implement the styling by only generic code, we need to create a 'SpanMention' or something similar.
There was a problem hiding this comment.
Created new Component HtmlTagSpanMention .
src/html/tags/HtmlTagSpan.js
Outdated
|
|
||
| mentionButtonRefersToSelf = () => { | ||
| const { attribs, ownEmail } = this.props; | ||
| return attribs && attribs.class === 'user-mention' && attribs['data-user-email'] === ownEmail; |
There was a problem hiding this comment.
Considering that the mention-self span already have a class called 'user-mention-me', this is likely too much complication.
|
Updated |
|
Looks good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.