Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release build through command line errors #940

Merged
merged 2 commits into from Jul 29, 2017

Conversation

Projects
None yet
5 participants
@kunall17
Copy link
Contributor

kunall17 commented Jul 28, 2017

Now the react-native run-ios --configuration Release works now, without any changes

Requires test from multiple people to make sure it works for everyone and not only my setup!

@smarx

This comment has been minimized.

Copy link

smarx commented Jul 28, 2017

Automated message from Dropbox CLA bot

@kunall17, it looks like you've already signed the Dropbox CLA. Thanks!

@kunall17 kunall17 force-pushed the kunall17:fix-errors branch from 99f921a to a641aab Jul 28, 2017

@@ -1191,7 +1249,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "export SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/sentry-cli-binary/bin/sentry-cli react-native xcode ../node_modules/react-native/scripts/react-native-xcode.sh";
shellScript = "if [[ $SDKROOT == *\"iPhoneSimulator10\"* ]]; then\necho [Bundle React Native code and images] Skipping sentry\n../node_modules/react-native/scripts/react-native-xcode.sh\nelse\nexport SENTRY_PROPERTIES=sentry.properties\nexport NODE_BINARY=node\n../node_modules/sentry-cli-binary/bin/sentry-cli react-native xcode ../node_modules/react-native/scripts/react-native-xcode.sh\nfi";

This comment has been minimized.

@borisyankov

borisyankov Jul 28, 2017

Contributor

Will not that be version 10 specific regex?

This comment has been minimized.

@kunall17

kunall17 Jul 28, 2017

Author Contributor

Done!

@zulipbot zulipbot added reviewed and removed needs review labels Jul 28, 2017

defaults.org=zulip
defaults.project=zulip-mobile
auth.token=ADD-DSN-HERE
auth.token=ADD-TOKEN-HERE

This comment has been minimized.

@borisyankov

This comment has been minimized.

@kunall17

kunall17 Jul 28, 2017

Author Contributor

As specified getsentry/react-native-sentry#140 (comment) here its auth token there and not dsn!

@@ -10,7 +11,7 @@ import config from './config';

require('./i18n/locale');

if (config.enableSentry) {
if (config.enableSentry && !DeviceInfo.isEmulator()) {

This comment has been minimized.

@borisyankov

borisyankov Jul 28, 2017

Contributor

You can add this logic to 'config.enableSentry'.

This comment has been minimized.

@kunall17

kunall17 Jul 28, 2017

Author Contributor

Getting this error in unit test's if I use

import DeviceInfo from 'react-native-device-info';

in the config.js

    TypeError: _reactNativeDeviceInfo2.default.isSimulator is not a function
      
      at Object.<anonymous> (src/config.js:5:76)
      at Object.<anonymous> (src/api/checkCompatibility.js:2:13)
      at Object.<anonymous> (src/api/index.js:2:37)

@kunall17 kunall17 force-pushed the kunall17:fix-errors branch from a641aab to fddcd4c Jul 28, 2017

@zulipbot zulipbot added needs review and removed reviewed labels Jul 28, 2017

@kunall17

This comment has been minimized.

Copy link
Contributor Author

kunall17 commented Jul 29, 2017

Btw, this fixes the react-native run-ios debug configuration as well! :)

@Sam1301

This comment has been minimized.

Copy link
Member

Sam1301 commented Jul 29, 2017

this fixes the error in release and debug build for me 👍

@borisyankov borisyankov merged commit 105adcf into zulip:master Jul 29, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
coverage/coveralls Coverage remained the same at 43.223%
Details

@zulipbot zulipbot removed the needs review label Jul 29, 2017

@borisyankov

This comment has been minimized.

Copy link
Contributor

borisyankov commented Jul 29, 2017

Looks good. Thanks.
That is quite an unblocking fix.

@kunall17 kunall17 referenced this pull request Jul 30, 2017

Closed

Build failed error #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.