tests: run: Use the tmp_path fixture instead of tmpdir.
#1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tmpdir` fixture under `pytest` is a `py.path.local` object, belonging to the `py` library, which is currently under maintenance mode, mentioned in the note here: https://py.readthedocs.io/en/latest/path.html#py-path. This commit migrates from `tmpdir` to using the `tmp_path` fixture instead, which is a `pathlib.Path` object. Reference: https://docs.pytest.org/en/6.2.x/tmpdir.html
|
@prah23 Thanks for this - I just tagged it with a Another good refactor sweep to look at would be to be consistent with using using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit structure:
tmp_pathfixture instead oftmpdir.The
tmpdirfixture underpytestis apy.path.localobject,belonging to the
pylibrary, which is currently under maintenancemode, mentioned in the note here:
https://py.readthedocs.io/en/latest/path.html#py-path.
This commit migrates from
tmpdirto using thetmp_pathfixtureinstead, which is a
pathlib.Pathobject.Reference: https://docs.pytest.org/en/6.2.x/tmpdir.html
Testing and linting:
I've ran tests locally on each commit. I've also ran
blackchecks and then the more extensive./tools/lint-all.