From 674a5fef5454834d7532f9445249501d37608c08 Mon Sep 17 00:00:00 2001
From: Abhijeet Prasad Bodas <abhijeetbodas2001@gmail.com>
Date: Sun, 14 Feb 2021 17:25:03 +0530
Subject: [PATCH] node tests: Split draft_model for add/edit/delete cases.

This splits the one big `run_test` block into
add/edit/delete parts, for better clarity.

This also removes the `with_field` calls and
uses the override style instead, which is
preferred because it makes sure the stubbed
function is actually called.
---
 frontend_tests/node_tests/drafts.js | 88 ++++++++++++++---------------
 1 file changed, 41 insertions(+), 47 deletions(-)

diff --git a/frontend_tests/node_tests/drafts.js b/frontend_tests/node_tests/drafts.js
index cfc61a271480d..29b8a4fc5c177 100644
--- a/frontend_tests/node_tests/drafts.js
+++ b/frontend_tests/node_tests/drafts.js
@@ -3,7 +3,7 @@
 const {strict: assert} = require("assert");
 
 const {stub_templates} = require("../zjsunit/handlebars");
-const {set_global, with_field, zrequire} = require("../zjsunit/namespace");
+const {set_global, zrequire, with_overrides} = require("../zjsunit/namespace");
 const {run_test} = require("../zjsunit/test");
 const {make_zjquery} = require("../zjsunit/zjquery");
 
@@ -47,13 +47,6 @@ set_global("page_params", {
     twenty_four_hour_time: false,
 });
 
-function stub_timestamp(timestamp, func) {
-    function fake_time() {
-        return timestamp;
-    }
-    with_field(Date, "now", fake_time, func);
-}
-
 const legacy_draft = {
     stream: "stream",
     subject: "lunch",
@@ -91,56 +84,57 @@ run_test("legacy", () => {
     assert.deepEqual(drafts.restore_message(legacy_draft), compose_args_for_legacy_draft);
 });
 
-run_test("draft_model", () => {
+run_test("draft_model add", (override) => {
     const draft_model = drafts.draft_model;
     const ls = localstorage();
-
-    localStorage.clear();
-    (function test_get() {
-        const expected = {id1: draft_1, id2: draft_2};
-        ls.set("drafts", expected);
-
-        assert.deepEqual(draft_model.get(), expected);
-    })();
-
     localStorage.clear();
-    (function test_get() {
-        ls.set("drafts", {id1: draft_1});
+    assert.equal(ls.get("draft"), undefined);
 
-        assert.deepEqual(draft_model.getDraft("id1"), draft_1);
-        assert.equal(draft_model.getDraft("id2"), false);
-    })();
+    override(Date, "now", () => 1);
+    const expected = {...draft_1};
+    expected.updatedAt = 1;
+    const id = draft_model.addDraft({...draft_1});
+    assert.deepEqual(draft_model.getDraft(id), expected);
+});
 
+run_test("draft_model edit", () => {
+    const draft_model = drafts.draft_model;
+    const ls = localstorage();
     localStorage.clear();
-    (function test_addDraft() {
-        stub_timestamp(1, () => {
-            const expected = {...draft_1};
-            expected.updatedAt = 1;
-            const id = draft_model.addDraft({...draft_1});
+    assert.equal(ls.get("draft"), undefined);
+    let id;
+
+    with_overrides((override) => {
+        override(Date, "now", () => 1);
+        const expected = {...draft_1};
+        expected.updatedAt = 1;
+        id = draft_model.addDraft({...draft_1});
+        assert.deepEqual(draft_model.getDraft(id), expected);
+    });
 
-            assert.deepEqual(ls.get("drafts")[id], expected);
-        });
-    })();
+    with_overrides((override) => {
+        override(Date, "now", () => 2);
+        const expected = {...draft_2};
+        expected.updatedAt = 2;
+        draft_model.editDraft(id, {...draft_2});
+        assert.deepEqual(draft_model.getDraft(id), expected);
+    });
+});
 
+run_test("draft_model delete", (override) => {
+    const draft_model = drafts.draft_model;
+    const ls = localstorage();
     localStorage.clear();
-    (function test_editDraft() {
-        stub_timestamp(2, () => {
-            ls.set("drafts", {id1: draft_1});
-            const expected = {...draft_2};
-            expected.updatedAt = 2;
-            draft_model.editDraft("id1", {...draft_2});
+    assert.equal(ls.get("draft"), undefined);
 
-            assert.deepEqual(ls.get("drafts").id1, expected);
-        });
-    })();
-
-    localStorage.clear();
-    (function test_deleteDraft() {
-        ls.set("drafts", {id1: draft_1});
-        draft_model.deleteDraft("id1");
+    override(Date, "now", () => 1);
+    const expected = {...draft_1};
+    expected.updatedAt = 1;
+    const id = draft_model.addDraft({...draft_1});
+    assert.deepEqual(draft_model.getDraft(id), expected);
 
-        assert.deepEqual(ls.get("drafts"), {});
-    })();
+    draft_model.deleteDraft(id);
+    assert.deepEqual(draft_model.getDraft(id), false);
 });
 
 run_test("snapshot_message", (override) => {