From 67f35d913adc5e9206b56187ca4ca5e13e2b438e Mon Sep 17 00:00:00 2001 From: Palash Date: Thu, 28 Oct 2021 09:55:23 +0530 Subject: [PATCH] capitalization: Add 'I understand' to the IGNORED_PHRASES list. String 'Here are a few messages I understand:'(next commit) was failing ./tools/check-capitalization check because of the capital I. I added 'I understand' to the IGNORED_PHRASES list in tools/lib/capitalization.py. Adding "I" was working as well but didn't seem to me as a very great fix. Strangely enough, adding " I " to the list made the test fail again (With a lot of failed strings this time) as mentioned in the following CZO thread. Relevent CZO chat - https://chat.zulip.org/#narrow/stream/49-development-help/topic/capitalization.20confusion.2E --- tools/lib/capitalization.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/capitalization.py b/tools/lib/capitalization.py index 8b4445a91fa26..dce2de2b8d85a 100644 --- a/tools/lib/capitalization.py +++ b/tools/lib/capitalization.py @@ -72,6 +72,7 @@ r".zuliprc", r"__\w+\.\w+__", # Things using "I" + r"I understand", r"I say", r"I want", r"I'm",