Permalink
Browse files

presence: Change "unknown" to "offline".

We never make an actionable distinction between the "unknown"
presence status and the "offline" status, so we now
just use "offline" as the status for persons who don't
have recent presence records that the client knows about.

(Usually, users without presence rows have never been online,
or they have been deactivated, or they have been offline so long
that they don't show up in our date-limited queries.)
  • Loading branch information...
showell authored and timabbott committed Oct 12, 2017
1 parent 8593c25 commit ae139a78b89076ec9f75f30b53a647feeabbb609
Showing with 2 additions and 2 deletions.
  1. +1 −1 frontend_tests/node_tests/activity.js
  2. +1 −1 static/js/presence.js
@@ -123,7 +123,7 @@ presence.presence_info = presence_info;
assert.equal(presence.get_status(page_params.user_id), "active");
assert.equal(presence.get_status(alice.user_id), "inactive");
assert.equal(presence.get_status(fred.user_id), "active");
assert.equal(presence.get_status(zoe.user_id), "unknown");
assert.equal(presence.get_status(zoe.user_id), "offline");
}());
(function test_reload_defaults() {
View
@@ -39,7 +39,7 @@ exports.get_status = function (user_id) {
if (user_id in exports.presence_info) {
return exports.presence_info[user_id].status;
}
return "unknown";
return "offline";
};
exports.get_user_ids = function () {

0 comments on commit ae139a7

Please sign in to comment.