Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetOldMessagesTest.post_with_params -> GetOldMessagesTest.get_messages #1386

Closed
showell opened this issue Jul 23, 2016 · 0 comments
Closed

GetOldMessagesTest.post_with_params -> GetOldMessagesTest.get_messages #1386

showell opened this issue Jul 23, 2016 · 0 comments
Labels
area: testing-coverage help wanted

Comments

@showell
Copy link
Contributor

showell commented Jul 23, 2016

See #1315. I am just splitting it out into its own issue. This is also very closely tied to #1382
showell added a commit to showell/zulip that referenced this issue Jul 24, 2016
@showell
Extracted test helper: get_and_check_messages().
dc0097b 
This new helper combines two old helpers, one of which was misnamed
and the other of which was always called after the first, so it
made sense to just combine the helpers.

Fixes: zulip#1386
showell added a commit to showell/zulip that referenced this issue Jul 24, 2016
@showell
Extracted test helper: get_and_check_messages().
9463163 
This new helper combines two old helpers, one of which was misnamed
and the other of which was always called after the first, so it
made sense to just combine the helpers.

Fixes: zulip#1386
@showell showell mentioned this issue Jul 24, 2016
Closed
showell added a commit to showell/zulip that referenced this issue Jul 24, 2016
@showell
Extracted test helper: get_and_check_messages().
2107fe9 
This new helper combines two old helpers, one of which was misnamed
and the other of which was always called after the first, so it
made sense to just combine the helpers.

Fixes: zulip#1386
@showell showell mentioned this issue Jul 24, 2016
Closed
umkay pushed a commit to umkay/zulip that referenced this issue Aug 16, 2016
@showell @umkay
Extracted test helper: get_and_check_messages().
43874f7 
This new helper combines two old helpers, one of which was misnamed
and the other of which was always called after the first, so it
made sense to just combine the helpers.

Fixes: zulip#1386
TomaszKolek pushed a commit to TomaszKolek/zulip that referenced this issue Aug 25, 2016
@showell
Extracted test helper: get_and_check_messages().
4f433e8 
This new helper combines two old helpers, one of which was misnamed
and the other of which was always called after the first, so it
made sense to just combine the helpers.

Fixes: zulip#1386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testing-coverage help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@showell @timabbott