Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display only message/mention notification counts #1736

Closed
akashnimare opened this issue Aug 30, 2016 · 15 comments

Comments

@akashnimare
Copy link
Member

commented Aug 30, 2016

Instead of showing count of all notifications we should include an option to display notification counts of private message/mentions only. Notifications counts gets noisy some time.
image

Also https://github.com/zulip/zulip-electron/issues/54.

@showell

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2016

Yeah, I'd like to consider just simplifying this for everybody. Having two three-digit numbers show up in the tab seems kind of cluttered.

@timabbott

This comment has been minimized.

Copy link
Member

commented Sep 8, 2016

Yeah, seems like we should probably do 2 things:
(1) Eliminate the number and just rely on the favicon count
(2) Add an option to allow a user to configure Zulip to only show mention/PM counts in the favicon. I think there's been some discussion of this broader topic in another issue as well...

@catxeger

This comment has been minimized.

Copy link

commented Jul 17, 2017

Having an option to only show mention and/or PM counts in the favicon would be a plus.

@timabbott

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

@catxeger thanks for the feedback! I think there's been enough interest in this from different folks over time that it's reasonable for someone to implement. The setting piece can be done following http://zulip.readthedocs.io/en/latest/new-feature-tutorial.html (the setting should go in "notification settings"), and the actual logic for the count computation I think goes in static/js/notifications.js.

This is probably a fine project for someone new to the Zulip codebase.

@YJDave

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2017

@zulipbot claim

@zulipbot

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

Hello @YJDave, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@YJDave

This comment has been minimized.

Copy link
Collaborator

commented Oct 23, 2017

@zulipbot claim, working on this

YJDave added a commit to YJDave/zulip that referenced this issue Oct 24, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Oct 24, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Oct 24, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Oct 26, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Oct 26, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Oct 26, 2017
@YJDave

This comment has been minimized.

Copy link
Collaborator

commented Oct 30, 2017

@akashnimare PR #7147 is ready for review :)

YJDave added a commit to YJDave/zulip that referenced this issue Nov 11, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Nov 21, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Nov 21, 2017
@zulipbot

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

Hello @YJDave, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@zulipbot zulipbot removed the in progress label Dec 8, 2017

YJDave added a commit to YJDave/zulip that referenced this issue Dec 12, 2017
YJDave added a commit to YJDave/zulip that referenced this issue Dec 14, 2017
@Rajamanickam1999

This comment has been minimized.

Copy link

commented Jan 17, 2019

@timabbott I would like to work on this issue ,before that I need to get clear with the problem statement ,what I understood is " We need to display only the count of private and mentioned messages "
Is my assumption correct ,If yes please reply, I would like to work on it

@harry-hov

This comment has been minimized.

Copy link
Collaborator

commented Mar 24, 2019

@zulipbot claim

@zulipbot

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Hello @harry-hov, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@alicewu8

This comment has been minimized.

Copy link
Collaborator

commented Apr 7, 2019

@zulipbot claim

@zulipbot

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Welcome to Zulip, @alicewu8! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@blinry

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

I would love it if this functionality was added, to be able to configure how notifications are displayed in the favicon! 💚 I have my Zulip tab pinned in my browser, but I don't want to be distracted each time, someone write a message. I think @YJDave has worked on this in #7147, but it's not yet rebased & merged. :)

timabbott added a commit to davidtwco/zulip that referenced this issue Jul 10, 2019
notifications: Allow only notifiable in unread count.
This commit adds a new setting to the user's notification settings that
will change the behaviour of the unread count in the title bar and
desktop application.

When enabled, the title bar will show the count of unread private messages
and mentions. When disabled, the title bar will act as before, showing
the total number of unread messages.

Fixes zulip#1736.
davidtwco added a commit to davidtwco/zulip that referenced this issue Jul 10, 2019
notifications: Allow only notifiable in unread count.
This commit adds a new setting to the user's notification settings that
will change the behaviour of the unread count in the title bar and
desktop application.

When enabled, the title bar will show the count of unread private messages
and mentions. When disabled, the title bar will act as before, showing
the total number of unread messages.

Fixes zulip#1736.

@timabbott timabbott closed this in 9bace3f Jul 13, 2019

@zulipbot zulipbot removed the in progress label Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.