Use a stable Django release #3

Closed
cjb opened this Issue Sep 25, 2015 · 4 comments

Projects

None yet

3 participants

@cjb
cjb commented Sep 25, 2015

Looks like Zulip's currently installing a random (non-release) commit of a personal fork of Django:

git+https://github.com/rwbarton/django.git@59f1fc4c7b65d23fceffd5c87e2b6ea350030c56

Does anyone know if there are obstacles to using a release version? Looks like this is from the 1.7alpha period, not sure whether pre- or post-migrations landing. If it's after migrations, maybe 1.7.x would just work?

@timabbott
Member

The only obstacle is the bulk_create feature we added to django. pull request is here: django/django#5166

@andersk
Contributor
andersk commented Sep 25, 2015

For the record, rwbarton/django@59f1fc4 isn’t from the 1.7alpha period; it’s five commits on top of the 1.8 final release.

@timabbott
Member

Thanks to @blablacio's work, the feature that caused Zulip to need a forked Django is now in mainline Django via django/django#5936 !

So we should be able to remove the fork sometime after Django 1.10 comes out (scheduled for July, see https://code.djangoproject.com/wiki/Version1.10Roadmap).

@timabbott timabbott added this to the 2016 roadmap milestone Apr 29, 2016
@timabbott timabbott modified the milestone: Zulip roadmap, Old roadmap Nov 18, 2016
@timabbott timabbott added a commit that closed this issue Dec 15, 2016
@umairwaheed @timabbott umairwaheed + timabbott Upgrade to the latest Django release, 1.10.4.
Most of the changes to support this were merged some time ago; what
remains are these changes:

* Update requirements.txt
* Django 1.10: Upgrade success-http-headers.txt file.

- We no longer get the absolute urls, see
  https://docs.djangoproject.com/en/1.10/releases/1.9/#http-redirects-no-longer-forced-to-absolute-uris
- The headers are capitalized, previously, they were in upper case.

* Bump PROVISON_VERSION to 3.0 since this is a disruptive change.

Fixes #3.
efccefc
@timabbott timabbott closed this in efccefc Dec 15, 2016
@timabbott
Member

We're now on the latest Django, 1.10.4, which has all of our patches merged. Yay for closing a super-early issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment