Attempting to start a reply to a message you're editing doesn't work #3938

timabbott · 2017-03-05T03:32:23Z

This is a somewhat tricky issue that we need to think about carefully. Right now, the behavior is weird, in that your mouse moves to a pointer "something will happen if you click" when you move it over any of the yellow areas of the message body:

Yep clicking does nothing; I imagine users expect that it would open the compose box (as happens if you click on other messages).

Update by @alya (2023-10):

The mouse currently looks like an arrow or a hand pointer, depending on where you are hovering. We now have formatting buttons in the message editing area, and it's therefore helpful to have the pointer change when you are over a formatting button. I think the right solution with the current UI is to have the mouse look like an arrow (not inviting clicks) in the unused spaces in the message editing area, with clicking there having no action.

zulipbot · 2017-03-05T03:32:24Z

Hello @zulip/server-message-view members, this issue was labeled with the area: message-editing label, so you may want to check it out!

lonerz · 2017-03-06T08:23:14Z

This action makes the most sense to me. However, it shouldn't only apply to messages that you're editing, but also messages that you're looking at the sources of.

novokrest · 2018-03-28T18:31:21Z

@zulipbot claim

zulipbot · 2018-03-28T18:31:27Z

Hello @novokrest, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

novokrest · 2018-03-28T18:50:18Z

@timabbott It seems there is related issue #3992. Whether it is appropriate to combine these issues? So, when user clicks on yellow area we should ask if he want to cancel his edit or go back to editing:

if he decide to cancel his edit then we close editing window and open the compose box.
if he decide to continue editing then we set focus on editing area

timabbott · 2018-03-28T19:25:35Z

Well, I think this issue is mostly one of the clicker handlers; if a user hovers on the being-edited message's e.g. top frame (everything not part of the message-edit form), it should show a pointer and clicking should start compose; and if they're over the message-edit form, it should not show a pointer.

novokrest · 2018-04-08T12:03:23Z

I have a little doubt about the opening of compose box while some message are edited. Because there is explicit handling of this case in click_handlers.js:128:

            if (message_edit.is_editing(id)) {
                // Clicks on a message being edited shouldn't trigger a reply.
                return;
            }

@timabbott Should we change the current behavior? If we decide to open a compose-box, should we close the current message-edit form (and cancel editing)?

Fixes zulip#3938

novokrest · 2018-04-08T13:57:15Z

@zulipbot claim

timabbott · 2018-04-08T23:26:25Z

#9025 looks correct for the cursor piece.

@rishig what are your thoughts on the correct behavior here? I guess my view is the area that's not part of the message-edit form (and that form in my mind includes the area with the buttons below, but not the address line above, the actual text areas), then it should do the normal reply thing when you click.

Fixes part of #3938. (This only changes the sections within the message-edit form; the top and left chrome are still cursor: pointer).

zulipbot · 2018-04-19T00:11:42Z

Hello @sletap, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

rishig · 2018-04-19T01:33:13Z

yeah, that seems reasonable, given that we open compose for clicking on any of the other messages.

zulipbot · 2018-04-29T06:11:39Z

Hello @novokrest, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot · 2018-05-07T12:11:56Z

ERROR: This active issue has no assignee.

zulipbot · 2018-05-11T12:11:58Z

ERROR: This active issue has no assignee.

zulipbot · 2018-05-15T12:12:14Z

ERROR: This active issue has no assignee.

Fixes part of zulip#3938. (This only changes the sections within the message-edit form; the top and left chrome are still cursor: pointer).

RDDeglurkar · 2019-08-23T20:51:15Z

Hi, I would like to work on this issue

sletap · 2019-11-19T03:48:38Z

@zulipbot claim

zulipbot · 2023-11-28T09:49:38Z

@grwt You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

sanchi-t · 2023-12-15T12:39:03Z

@zulipbot claim

zulipbot · 2023-12-15T12:39:05Z

Welcome to Zulip, @sanchi-t! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

Fixes zulip#3938. Addressing the issue where the cursor appears as an arrow or hand pointer inappropriately in the message editing area. By change in css style of `&.content_edit_mode` selector the cursor appears to be arrow on hover. Change in `.sender_name_hovered` selector css makes the cursor hand pointer when hovered over name or avatar.

sanchi-t · 2023-12-15T19:38:10Z

This is my first PR for Zulip. I'm new to open source, so any input would be much appreciated. Even though I followed the documentation the entire time, if anything is incorrect or should be improved, please let me know.

Fixes zulip#3938. The cursor appears to be hand pointer when hovered over empty area, giving the user the impression that it is clickable. By adjusting CSS properties, the cursor now correctly changes into hand pointer when hovered only over clickable items.

Fixes zulip#3938.

sanchi-t · 2023-12-22T07:01:27Z

Considering that most of the work has been completed, I am unassigning myself. However, I will continue working on it and update the pull request if needed.

@zulipbot abandon

Fixes zulip#3938.

Mubashir2611 · 2023-12-26T12:25:52Z

@zulipbot claim

zulipbot · 2023-12-26T12:25:55Z

Welcome to Zulip, @Mubashir2611! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

Fixes #3938.

Fixes zulip#3938.

timabbott added area: message-editing good first issue bug feedback wanted help wanted labels Mar 5, 2017

novokrest added a commit to novokrest/zulip that referenced this issue Apr 8, 2018

message_edit_form: Show default cursor instead of pointer.

fe78c11

Fixes zulip#3938

novokrest mentioned this issue Apr 8, 2018

#3938 Show default cursor inside message_edit_form #9025

Closed

zulipbot assigned novokrest Apr 8, 2018

zulipbot added the in progress label Apr 8, 2018

timabbott pushed a commit that referenced this issue Apr 12, 2018

message_edit_form: Show default cursor instead of pointer.

0d164fa

Fixes part of #3938. (This only changes the sections within the message-edit form; the top and left chrome are still cursor: pointer).

zulipbot unassigned novokrest May 3, 2018

synicalsyntax removed the in progress label May 18, 2018

zulipbot added the in progress label Nov 18, 2023

zulipbot unassigned grwt Dec 2, 2023

zulipbot removed the in progress label Dec 2, 2023

zulipbot assigned sanchi-t Dec 15, 2023

zulipbot added the in progress label Dec 15, 2023

sanchi-t mentioned this issue Dec 15, 2023

Cursor style on hover #3938 #28253

Merged

12 tasks

sanchi-t added a commit to sanchi-t/zulip that referenced this issue Dec 15, 2023

Fixes zulip#3938.

2b97e3f

sanchi-t added a commit to sanchi-t/zulip that referenced this issue Dec 19, 2023

message_edit: Fix cursor style on hover in edit area.

fe4c03a

Fixes zulip#3938.

zulipbot unassigned sanchi-t Dec 22, 2023

zulipbot removed the in progress label Dec 22, 2023

sanchi-t added a commit to sanchi-t/zulip that referenced this issue Dec 22, 2023

message_edit: Fix cursor style on hover in edit area.

9d29562

Fixes zulip#3938.

sanchi-t added a commit to sanchi-t/zulip that referenced this issue Dec 24, 2023

message_edit: Fix cursor style on hover in edit area.

002e2c0

Fixes zulip#3938.

zulipbot assigned Mubashir2611 Dec 26, 2023

zulipbot added the in progress label Dec 26, 2023

Mubashir2611 added a commit to Mubashir2611/zulip that referenced this issue Dec 26, 2023

issue zulip#3938 fix the cursor changing issue

b72e873

timabbott closed this as completed in #28253 Jan 14, 2024

timabbott pushed a commit that referenced this issue Jan 14, 2024

message_edit: Fix cursor style on hover in edit area.

446ba4d

Fixes #3938.

mananbordia pushed a commit to mananbordia/zulip that referenced this issue Feb 27, 2024

message_edit: Fix cursor style on hover in edit area.

b035176

Fixes zulip#3938.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attempting to start a reply to a message you're editing doesn't work #3938

Attempting to start a reply to a message you're editing doesn't work #3938

timabbott commented Mar 5, 2017 •

edited by alya

zulipbot commented Mar 5, 2017

lonerz commented Mar 6, 2017

novokrest commented Mar 28, 2018

zulipbot commented Mar 28, 2018

novokrest commented Mar 28, 2018

timabbott commented Mar 28, 2018

novokrest commented Apr 8, 2018

novokrest commented Apr 8, 2018

timabbott commented Apr 8, 2018

zulipbot commented Apr 19, 2018 •

edited

rishig commented Apr 19, 2018

zulipbot commented Apr 29, 2018 •

edited

zulipbot commented May 7, 2018

zulipbot commented May 11, 2018

zulipbot commented May 15, 2018

RDDeglurkar commented Aug 23, 2019

sletap commented Nov 19, 2019

zulipbot commented Nov 28, 2023 •

edited

sanchi-t commented Dec 15, 2023

zulipbot commented Dec 15, 2023

sanchi-t commented Dec 15, 2023

sanchi-t commented Dec 22, 2023

Mubashir2611 commented Dec 26, 2023

zulipbot commented Dec 26, 2023

Attempting to start a reply to a message you're editing doesn't work #3938

Attempting to start a reply to a message you're editing doesn't work #3938

Comments

timabbott commented Mar 5, 2017 • edited by alya

zulipbot commented Mar 5, 2017

lonerz commented Mar 6, 2017

novokrest commented Mar 28, 2018

zulipbot commented Mar 28, 2018

novokrest commented Mar 28, 2018

timabbott commented Mar 28, 2018

novokrest commented Apr 8, 2018

novokrest commented Apr 8, 2018

timabbott commented Apr 8, 2018

zulipbot commented Apr 19, 2018 • edited

rishig commented Apr 19, 2018

zulipbot commented Apr 29, 2018 • edited

zulipbot commented May 7, 2018

zulipbot commented May 11, 2018

zulipbot commented May 15, 2018

RDDeglurkar commented Aug 23, 2019

sletap commented Nov 19, 2019

zulipbot commented Nov 28, 2023 • edited

sanchi-t commented Dec 15, 2023

zulipbot commented Dec 15, 2023

sanchi-t commented Dec 15, 2023

sanchi-t commented Dec 22, 2023

Mubashir2611 commented Dec 26, 2023

zulipbot commented Dec 26, 2023

timabbott commented Mar 5, 2017 •

edited by alya

zulipbot commented Apr 19, 2018 •

edited

zulipbot commented Apr 29, 2018 •

edited

zulipbot commented Nov 28, 2023 •

edited