Manage or Delete your uploads #454

Closed
asmartin opened this Issue Jan 30, 2016 · 7 comments

Projects

None yet

4 participants

@asmartin

Would it be possible to add a view where you can see all of your uploads, with a button to delete them? I can think of a number of use cases where you would not want old uploads being available after a short period of time.

@timabbott
Member

Yeah I think this is a feature Zulip should have.

@timabbott
Member

To provide some notes for what'd be involved in adding this, currently Zulip doesn't actually store in its own database which files were uploaded by which users (instead the data is stored as metadata in S3). So either we need to write code to query S3 for the metadata, or (likely simpler) have Zulip start storing the metadata in a new database table declared in models.py.

To start on this feature, one will probably want to start by setting up the Amazon S3 integration in their development environment, and then modify zerver/lib/upload.py to start recording the data needed for this. Then we can work on adding the new view to display the uploads.

@rahuldeve
Contributor

@timabbott
Currently zulip stores attachments without actually checking if they are being referenced in the message being sent(the sender can just remove the upload string after the upload). This will cause a major problem in implementing this. Ive made a PR to address this #584

@wdaher wdaher referenced this issue in timabbott/zulip Apr 10, 2016
@timabbott timabbott Add a draft roadmap doc. ec34f29
@timabbott timabbott added this to the 2016 roadmap milestone Apr 29, 2016
@timabbott
Member

Just a quick update on this issue, thanks to some great work by @rahuldeve, we now track all new uploaded files in the Attachment model in the database; so this project is now primarily one of building a UI for managing uploads...

@timabbott timabbott modified the milestone: Zulip roadmap, Old roadmap Nov 18, 2016
@paxapy
Contributor
paxapy commented Dec 21, 2016

hi
i've noticed that to create such UI I'll need to continue work on new popup settings interface.
from which branch can I checkout to use it?

@timabbott
Member

Hmm, yeah, let me try to merge that branch as it'll make life easier here.

@timabbott
Member

the timabbott/settings-redesign branch works. It currently fails casper tests (needs changes to the tests) but is otherwise final; so just ignore casper tests for now.

@paxapy paxapy referenced this issue Dec 28, 2016
Closed

Manage uploads #2961

@timabbott timabbott added a commit to timabbott/zulip that referenced this issue Feb 17, 2017
@paxapy @timabbott paxapy + timabbott Add support for managing and deleting attachments.
Modified substantially by tabbott to fix tons of issues.

Fixes #454.
7056a7c
@timabbott timabbott added a commit that closed this issue Feb 17, 2017
@paxapy @timabbott paxapy + timabbott Add support for managing and deleting attachments.
Modified substantially by tabbott to fix tons of issues.

Fixes #454.
9a5179c
@timabbott timabbott closed this in 9a5179c Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment