Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UserProfile.short_name. #6949

Closed
showell opened this issue Oct 11, 2017 · 9 comments
Closed

Remove UserProfile.short_name. #6949

showell opened this issue Oct 11, 2017 · 9 comments

Comments

@showell
Copy link
Contributor

showell commented Oct 11, 2017

We no longer use UserProfile.short_name in any meaningful way, so we should sweep it from our code.

If you work on this, you should have some experience with doing full-stack stuff, and you'll want to communicate with the mobile team.

@zulipbot
Copy link
Member

Hello @zulip/server-refactoring members, this issue was labeled with the area: refactoring label, so you may want to check it out!

@modestlearner
Copy link
Collaborator

Can I take this up??

@showell
Copy link
Contributor Author

showell commented Oct 16, 2017

yep, @modestlearner, you can work on this...probably the first step is to remove short_name from static/js/*.js and static/templates in one or two atomic commits

@lonerz
Copy link
Member

lonerz commented Oct 16, 2017

@modestlearner you can claim this task by commenting @zulipbot claim

@modestlearner
Copy link
Collaborator

@showell Thanks for your support.
But can you please help me out with this as I am new to the community and want to contribute.

@showell
Copy link
Contributor Author

showell commented Jun 11, 2018

@adnrs96 @timabbott This might be a good thing to fix in light of UserProfile getting bigger and bigger. I'm also curious if there's been any last-minute defense of having the field around or at least migrating it to custom fields or something.

@timabbott
Copy link
Sponsor Member

Whether this makes sense to remove is pending some decisions around making email addresses private; we might end up reusing the field for that feature,

@punchagan
Copy link
Member

Short name doesn't seem to have been used for implementing the feature making email addresses private. Do we want to remove the short_name field?

@timabbott
Copy link
Sponsor Member

This was in fact removed a few years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants