Keep track of which users added which realm emoji. #984

Closed
jdherg opened this Issue Jun 8, 2016 · 3 comments

Projects

None yet

3 participants

@jdherg
Contributor
jdherg commented Jun 8, 2016

With the implementation of #978 , it's probably also useful to have an emoji audit trail of sorts. This could be as simple as adding a field for the user who added an emoji to the RealmEmoji model (and displaying it in the realm emoji settings pane) or might get more involved if we also want to track deletions.

@timabbott
Member

Yeah, this is a good idea. Should be an easy field to add to the RealmEmoji model.

@timabbott
Member
timabbott commented Jun 13, 2016 edited

I think a good implementation for this would be:

  • First, a commit adding the new field, including a database migration (seehttp://zulip.readthedocs.io/en/latest/new-feature-tutorial.html for details), and storing which user added the emoji when they are created in the RealmEmoji table.
  • Second, a commit causing the creator data to be included in the RealmEmoji.get_emoji data set, and
  • Third, a commit displaying which user added the emoji in the emoji template in static/templates/admin_emoji_list.handlebars.

I think we can leave tracking deletions for a future project.

@timabbott timabbott modified the milestone: Likely next milestone Jul 7, 2016
@edanaher
edanaher commented Oct 4, 2016

I'm going to take a look at this; it seems like a fairly straightforward first bug to look at.

@timabbott timabbott closed this in 3cb7d66 Dec 27, 2016
@KingxBanana KingxBanana added a commit to KingxBanana/zulip that referenced this issue Dec 28, 2016
@TigorC @KingxBanana TigorC + KingxBanana emoji: Display emoji author in admin interface.
Fixes: #984.
a2c2f7a
@picapi picapi added a commit to picapi/zulip that referenced this issue Dec 30, 2016
@TigorC @picapi TigorC + picapi emoji: Display emoji author in admin interface.
Fixes: #984.
e0581f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment