Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhooks/jira: Include issue title in messages. #12254

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
4 participants
@davidtwco
Copy link
Contributor

commented May 3, 2019

This pull request adds the issue title to the messages posted by the JIRA webhook integration. If the &topic= parameter is provided then the issue title isn't included anywhere in the message and lacks some context as a result.

Testing Plan:
I've updated the existing tests for the JIRA webhook.

GIFs or Screenshots:
In the below image, the link would normally not have included the : Webhook Test 2 text.

image

@zulipbot zulipbot added the size: M label May 3, 2019

@timabbott

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Looks reasonable to me; @eeshangarg can your review though?

I could imagine making this conditional on whether the topic is included, but it's probably clean enough as proposed in this PR.

@eeshangarg

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@davidtwco: Thanks for working on this! Looks great, merging! :)

@timabbott: I kinda agree, but custom topics are handled by check_send_webhook_message, and making this change conditional upon whether a custom topic is specified would probably be more work than its worth at this point in time, so I'm going to merge this. Having said that, ideally, I would love to see a system where the user has more control over custom topic and content templates when setting up the webhook, but that's a much more involved project and definitely out of the scope of this PR! Thanks! :)

@eeshangarg eeshangarg merged commit 16e9892 into zulip:master May 3, 2019

5 checks passed

ci/circleci: bionic-backend-python3.6 Your tests passed on CircleCI!
Details
ci/circleci: trusty-backend-frontend-python3.4 Your tests passed on CircleCI!
Details
ci/circleci: xenial-backend-python3.5 Your tests passed on CircleCI!
Details
codecov/project 91.31% (+<.01%) compared to b570c0d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidtwco davidtwco deleted the davidtwco:jira-include-title-in-message branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.