Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add british english locale. #12402
This pull request adds a “British English” locale with pre-populated translations. As a side effect, this also lets users of the Zulip Desktop app have a British English spellchecker.
GIFs or Screenshots:
@davidtwco cool, thanks for the contribution! Check out https://zulip.readthedocs.io/en/latest/translating/translating.html. We generally manage the locale files entirely by syncing data from Transifex; we never edit them directly (as they'd just be overwritten). Given that you've done the translations in this file, I think our options are to either:
(1) Manually enter the translations into Transifex
To start, can you sign up for Transifex and we can collaborate to figure out the right way to get the data in?
I had read that documentation, but was hoping that the GitHub repository was the source of truth and that Transifex would update from that (and that updating the repository manually was just discouraged due to being error prone).
I’ve signed up as davidtwco.
I have no experience with Transifex but would the
Also, seeing your confusion about our workflow here, I'm pretty sure that's the fault of our docs. I just did a rewrite of those docs to explain the workflow more clearly for a translator audience in 8a04284, and also opened #12414 for the follow-up work to make us have a great i18n landing page for Zulip developers to learn how to do it properly in the codebase.
Can you give the updated docs (https://zulip.readthedocs.io/en/latest/translating/translating.html) a read and provide feedback on anything that could be better (PR format or comment here are both reasonable formats).
So thanks for your comment above that made it clear to me we needed to improve this documentation!