Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add british english locale. #12402

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@davidtwco
Copy link
Contributor

commented May 24, 2019

This pull request adds a “British English” locale with pre-populated translations. As a side effect, this also lets users of the Zulip Desktop app have a British English spellchecker.

Testing Plan:
I’ve checked that python manage.py compilemessages works, have ran all the tests and manually reviewed the translations.

GIFs or Screenshots:
I’m submitting this from my phone so can’t provide any screenshots but this looks like you’d expect a new locale to look.

davidtwco added some commits May 24, 2019

@zulipbot zulipbot added the size: XL label May 24, 2019

@timabbott

This comment has been minimized.

Copy link
Member

commented May 24, 2019

@davidtwco cool, thanks for the contribution! Check out https://zulip.readthedocs.io/en/latest/translating/translating.html. We generally manage the locale files entirely by syncing data from Transifex; we never edit them directly (as they'd just be overwritten). Given that you've done the translations in this file, I think our options are to either:

(1) Manually enter the translations into Transifex
(2) Use the Transifex API to send these to Transifex, which I can potentially help with if my maintainer API credentials are needed.

To start, can you sign up for Transifex and we can collaborate to figure out the right way to get the data in?

@davidtwco

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

I had read that documentation, but was hoping that the GitHub repository was the source of truth and that Transifex would update from that (and that updating the repository manually was just discouraged due to being error prone).

To start, can you sign up for Transifex and we can collaborate to figure out the right way to get the data in?

I’ve signed up as davidtwco.

I have no experience with Transifex but would the tx push command work?

@timabbott

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Yeah, I think tx push with the right arguments should work. You may not have permissions to do that; I can try doing it.

Just invited you to the Transifex project; let me update those docs to be clear about how things work.

@timabbott

This comment has been minimized.

Copy link
Member

commented May 27, 2019

OK, I did the push required to push this content to Transifex for en_GB.

@timabbott

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Also, seeing your confusion about our workflow here, I'm pretty sure that's the fault of our docs. I just did a rewrite of those docs to explain the workflow more clearly for a translator audience in 8a04284, and also opened #12414 for the follow-up work to make us have a great i18n landing page for Zulip developers to learn how to do it properly in the codebase.

Can you give the updated docs (https://zulip.readthedocs.io/en/latest/translating/translating.html) a read and provide feedback on anything that could be better (PR format or comment here are both reasonable formats).

So thanks for your comment above that made it clear to me we needed to improve this documentation!

@timabbott timabbott closed this May 27, 2019

@davidtwco davidtwco deleted the davidtwco:add-british-english-locale branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.