Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about mentions in 1:1 private message conversations #18199

Closed
wants to merge 2 commits into from

Conversation

ChloeTang99
Copy link
Collaborator

Link to the issue: #17998

Tests: add node test case for warning function
HTML: edit compose.html to include div for warning
HTML: add .hbs file to render warning
typeahead: add warning call when mentioning

Added warning if mentioning a user in a one on one private message, per the issue.
Was done by editing HTML and adding a function call checking the parameters to call.
Tested to make sure it worked within the development environment and wrote test cases that check if warning appears in correct or incorrect spots

Screen Shot 2021-04-16 at 11 02 05 PM

@timabbott timabbott changed the title Add HTML and test case Warn about mentions in 1:1 private message conversations Apr 23, 2021
@timabbott
Copy link
Sponsor Member

@ChloeTang99 thanks for working on this. Can you please adjust this PR to follow Zulip's commit guidelines? I fixed the title of this PR, but you need to write a proper commit message. Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

@timabbott
Copy link
Sponsor Member

@ChloeTang99 ping on this.

@zulipbot
Copy link
Member

zulipbot commented Sep 7, 2021

Heads up @ChloeTang99, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

@timabbott
Copy link
Sponsor Member

Closing in favor of #27213 for this issue.

@timabbott timabbott closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants