Misc. changes #11

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants
@nirvdrum
Contributor

nirvdrum commented Sep 9, 2012

Hi,

There's a bunch of misc. changes made here. I don't expect you'll just blindly merge them. But if any seem interesting to you, please let me know and I'll pull out to a topic branch.

@skiz

This comment has been minimized.

Show comment Hide comment
@skiz

skiz Nov 26, 2013

Contributor

Thanks!
I have cherry picked several of these commits.
I would like to add your amend call, but it will require specs. If you have some please pass them this was, otherwise I may need to add some and pull it in separately..

Contributor

skiz commented Nov 26, 2013

Thanks!
I have cherry picked several of these commits.
I would like to add your amend call, but it will require specs. If you have some please pass them this was, otherwise I may need to add some and pull it in separately..

@ghost ghost assigned skiz Nov 26, 2013

@nirvdrum

This comment has been minimized.

Show comment Hide comment
@nirvdrum

nirvdrum Nov 26, 2013

Contributor

Unfortunately, I no longer work at the place where I was using Zuora. So I don't really have a testbed to try any of this out on. I'm not sure why I didn't write a spec for that, given I wrote specs for other calls. I think it was because the existing specs continued to pass.

I can put you in touch with someone at my previous employer. I know they were using these changes to process a sizeable number of transactions.

Contributor

nirvdrum commented Nov 26, 2013

Unfortunately, I no longer work at the place where I was using Zuora. So I don't really have a testbed to try any of this out on. I'm not sure why I didn't write a spec for that, given I wrote specs for other calls. I think it was because the existing specs continued to pass.

I can put you in touch with someone at my previous employer. I know they were using these changes to process a sizeable number of transactions.

@skiz

This comment has been minimized.

Show comment Hide comment
@skiz

skiz Nov 26, 2013

Contributor

No worries. I'll add some specs and get this merged in. I also saw a few
other branches that may be useful.
On Nov 26, 2013 1:53 PM, "Kevin Menard" notifications@github.com wrote:

Unfortunately, I no longer work at the place where I was using Zuora. So I
don't really have a testbed to try any of this out on. I'm not sure why I
didn't write a spec for that, given I wrote specs for other calls. I think
it was because the existing specs continued to pass.

I can put you in touch with someone at my previous employer. I know they
were using these changes to process a sizeable number of transactions.


Reply to this email directly or view it on GitHubhttps://github.com/wildfireapp/zuora/pull/11#issuecomment-29337882
.

Contributor

skiz commented Nov 26, 2013

No worries. I'll add some specs and get this merged in. I also saw a few
other branches that may be useful.
On Nov 26, 2013 1:53 PM, "Kevin Menard" notifications@github.com wrote:

Unfortunately, I no longer work at the place where I was using Zuora. So I
don't really have a testbed to try any of this out on. I'm not sure why I
didn't write a spec for that, given I wrote specs for other calls. I think
it was because the existing specs continued to pass.

I can put you in touch with someone at my previous employer. I know they
were using these changes to process a sizeable number of transactions.


Reply to this email directly or view it on GitHubhttps://github.com/wildfireapp/zuora/pull/11#issuecomment-29337882
.

@skiz

This comment has been minimized.

Show comment Hide comment
@skiz

skiz Nov 26, 2013

Contributor

The amend call has been merged in to the 1.0 branch. Thank you.

Contributor

skiz commented Nov 26, 2013

The amend call has been merged in to the 1.0 branch. Thank you.

@skiz skiz closed this Nov 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment