Zuora subscribe requests allow for multiple product rate plan objects (in my use case, this sometimes includes a normal subscription object, and an object that represents a discount). This is just a minor adjustment to add support for multiple product rate plans to the gem.
support multiple product rate plans in subscribe requests
adding method for backward compatibility of single product_rate_plan …
Added a backward compatibility method so that this change doesn't break everyone's existing integration.
On review, I realize that this pull request needs to have its specs beefed up. Will improve the tests as soon as I can. Thanks for not rejecting it out of hand.
product_rate_plan= method shouldn't be protected
DRYing object xml generation methods
specs to cover modifications to validation methods and turning produc…
…t_rate_plan into product_rate_plans
I think this one is ready to be looked at again. Added specs for both my validation change and the backwards compatibility method. The refactor of the xml generation methods is covered by existing specs.
Can one of the admins verify this patch?
I don't mean to seem ungrateful, because I'd like to get this patch reviewed (I have a few more to submit that depend on this change), but can the spamming please stop?
@jmoline I apologize for the spamming, something went wrong with our bot, I will escalate the issue!
No worries, the bot is a great idea! Just maybe needs to post a little less often :)
@jmoline It was disabled for Zuora, we are covered by Travis anyway.
@eMxyzptlk is there a status on this?
This has been merged in to the 1.0 branch