Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

support multiple product rate plans in subscribe requests #8

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

jmoline commented Jun 18, 2012

Zuora subscribe requests allow for multiple product rate plan objects (in my use case, this sometimes includes a normal subscription object, and an object that represents a discount). This is just a minor adjustment to add support for multiple product rate plans to the gem.

Contributor

jmoline commented Jun 18, 2012

Added a backward compatibility method so that this change doesn't break everyone's existing integration.

Contributor

jmoline commented Jun 25, 2012

On review, I realize that this pull request needs to have its specs beefed up. Will improve the tests as soon as I can. Thanks for not rejecting it out of hand.

Contributor

jmoline commented Jul 3, 2012

I think this one is ready to be looked at again. Added specs for both my validation change and the backwards compatibility method. The refactor of the xml generation methods is covered by existing specs.

Can one of the admins verify this patch?

Contributor

jmoline commented Apr 17, 2013

I don't mean to seem ungrateful, because I'd like to get this patch reviewed (I have a few more to submit that depend on this change), but can the spamming please stop?

Contributor

kalbasit commented Apr 17, 2013

@jmoline I apologize for the spamming, something went wrong with our bot, I will escalate the issue!

Contributor

jmoline commented Apr 17, 2013

No worries, the bot is a great idea! Just maybe needs to post a little less often :)

Contributor

kalbasit commented Apr 19, 2013

@jmoline It was disabled for Zuora, we are covered by Travis anyway.

Contributor

skiz commented Nov 26, 2013

@emxyzptlk is there a status on this?

Contributor

skiz commented Nov 26, 2013

This has been merged in to the 1.0 branch

@skiz skiz closed this Nov 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment