Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forms] Page Need to be updated with XY Grid Classes! #10452

Closed
IamManchanda opened this issue Jul 22, 2017 · 5 comments
Closed

[Forms] Page Need to be updated with XY Grid Classes! #10452

IamManchanda opened this issue Jul 22, 2017 · 5 comments

Comments

@IamManchanda
Copy link
Contributor

http://foundation.zurb.com/sites/docs/forms.html

Anybody would like to take this up ??

@colinmackinlay
Copy link
Contributor

I'll have a look - need a little project to learn XY grid anyway!

@sonicdivx
Copy link

Just saw your change. doesn't that break the intent of the row class? wonder if way to modify the row class to function differently within context of XY grid.

But, really like that you figured out a way to fix. I am using XY grid for a project and was getting frustrated with form layout

@colinmackinlay
Copy link
Contributor

Not sure what you mean @sonicdivx. My PR #10462 removes all references to the row class as I believe was requested.
What do you think @IamManchanda? Happy to tweak if I've got your intent wrong. If it's right then I'll do #10565 as well.

@IamManchanda
Copy link
Contributor Author

@colinmackinlay I am busy with some tasks but will soon review up your PR
Ofcourse, Go ahead with the PR for cards ... you don't need your code to be 100% correct to make a Pull request!

@sonicdivx
Copy link

yeah i was talking about carrying the row class into the XY grid. but if that is deprecated in XY grid then carry on :D

kball added a commit that referenced this issue Sep 8, 2017
[Forms] docs updated for XY Grid closes #10452
@kball kball closed this as completed in 30f4ccf Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants