Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-close-on-click option on dropdown does not work correctly #10657

Closed
bhupinderbola opened this issue Sep 18, 2017 · 2 comments
Closed

data-close-on-click option on dropdown does not work correctly #10657

bhupinderbola opened this issue Sep 18, 2017 · 2 comments

Comments

@bhupinderbola
Copy link
Contributor

bhupinderbola commented Sep 18, 2017

How to reproduce this bug:

  1. Open a dropdown with data-close-on-click="true"
  2. Click inside the dropdown

What should happen:

dropdown should not close

What happened instead:

dropdown closed

Browser(s) and Device(s) tested on:

Chrome

Foundation Version(s) you are using:

6.4.3

Test case link:

Inside _addBodyHandler method, following code need to be changed:
if(_this.$element.find(e.target).length) {
return;
}

it should be

if(_this.$element.is(e.target) || _this.$element.find(e.target).length) {
return;
}

@rafibomb
Copy link
Member

Closing for PR #10658**

@kball
Copy link
Contributor

kball commented Oct 3, 2017

@rafibomb typically we don't close until the PR is merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants