Orbit timer display issue when resetTimerOnClick enabled #1173

Closed
remosiegwart opened this Issue Nov 13, 2012 · 4 comments

2 participants

@remosiegwart

I'm using the following Orbit test page:
https://github.com/zurb/foundation/blob/17b88f9c9dd9c0665ab3827396b91f32eb5647cc/test/orbit.html#L101

When resetTimerOnClick is enabled and you wait more than half of the timer's time until you click, then the timer will start at the bottom for the next slide.

$(window).load(function(){
  $("#featured").orbit({
    resetTimerOnClick: true
  });
});
@mhayes

We had another similar issue filed earlier that addresses this bug, take a look at #818.

9c07225 fixes this particular issue. It will make it's way into the 3.2.3 release this Friday.

@remosiegwart

I'm already using the fixed version (I should have mentioned that). Sorry if I didn't explain it clear enough: clicking prev/next after at least half of the time has passed, the timer will be displayed upside down on the next slide.

@mhayes

Ah, thanks for pointing that out @remosiegwart. I didn't notice that initially ... I should have some time to look into fixing that later today.

If you have some time now though and want to submit a PR with a fix that would also be awesome!

@remosiegwart

No worries! I'm just testing the new features at the moment (which are great btw!) and want to report the issues I'm finding, just to make sure I don't forget them. Hope to find some time later this week to contribute. Thanks again for your help!

@remosiegwart remosiegwart added a commit to remosiegwart/foundation that referenced this issue Nov 14, 2012
@remosiegwart remosiegwart fixed timer display issue when resetTimerOnClick enabled #1173 036ee14
@mhayes mhayes was assigned Dec 5, 2012
@mhayes mhayes was unassigned by remosiegwart Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment