New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'top' of undefined foundation.min.js:98 #1395

Closed
zzramesses opened this Issue Jan 15, 2013 · 13 comments

Comments

Projects
None yet
7 participants
@zzramesses

zzramesses commented Jan 15, 2013

I just downloaded version 3.2.4 today. Getting the error above

@mhayes

This comment has been minimized.

Contributor

mhayes commented Jan 15, 2013

It appears that #1397 fixes this issue. We'll be getting this merged into master today.

@mhayes

This comment has been minimized.

Contributor

mhayes commented Jan 15, 2013

That has been fixed in master, cheers!

@mhayes mhayes closed this Jan 15, 2013

@zzramesses

This comment has been minimized.

zzramesses commented Jan 15, 2013

Hey Mark. My issue was in the foundation.min.js. That issue hasn't been fixed. That file doesn't exist in the master branch on github and I just re-downloaded the css version from the site and the error persists.

@mhayes

This comment has been minimized.

Contributor

mhayes commented Jan 15, 2013

Right, the change you're looking for hasn't been pushed out to point release yet, which is what the Foundation customizer uses to generate download packages. We should have another point release (3.2.5) that includes fixes for this bug (and a few others) within the next few days. Once that goes out the updates will be available on the Foundation website.

If you want a copy of this patch right away you can download the updated Magellan javascript file from here:
https://raw.github.com/zurb/foundation/master/vendor/assets/javascripts/foundation/jquery.foundation.magellan.js

Another option is to use Bundler/Compass and compile directly from the master branch which gets updated pretty regularly (but isn't as thoroughly tested). We have some instructions on how to do that here:
http://foundation.zurb.com/docs/compass.php#project-git

Cheers!

@zzramesses

This comment has been minimized.

zzramesses commented Jan 15, 2013

Thanks Mark. I fixed my version of foundation.min.js. I downloaded it specifically to use the sticky top-bar but it doesn't seem to be working. Should I open a seperate issue ticket for that?

@mhayes

This comment has been minimized.

Contributor

mhayes commented Jan 15, 2013

Sure go ahead and open a new issue for that, thanks!

@NeilJS

This comment has been minimized.

NeilJS commented Jan 16, 2013

Yes, this isn't too much of a problem in Chrome but stops all IE in its tracks.

@rassom

This comment has been minimized.

rassom commented Jan 21, 2013

Hi Mark,

When will this be fixed? I am using the Rails (pipeline) foundation gem, so I cannot fix myself ...

Thanks :)
Rasmus

@johnpolitowski

This comment has been minimized.

johnpolitowski commented Jan 24, 2013

Having the same issue. Has it been updated yet?

@rassom

This comment has been minimized.

rassom commented Jan 24, 2013

@mhayes Mark - can you help here, please?

@jtippett

This comment has been minimized.

jtippett commented Jan 25, 2013

+1 also having this issue. Hundreds of magellan errors on any scroll activity.

@AlJohri

This comment has been minimized.

AlJohri commented Jan 27, 2013

@rassom

Like @mhayes said
Just use: gem "zurb-foundation", :git => "git@github.com:zurb/foundation.git" in your Gemfile.

Or download https://raw.github.com/zurb/foundation/master/vendor/assets/javascripts/foundation/jquery.foundation.magellan.js
and replace your file. http://stackoverflow.com/a/6507034/1667241

@rassom

This comment has been minimized.

rassom commented Jan 27, 2013

For now I've solved it by specifying the earlier version in my gemfile:
gem "zurb-foundation", "< 3.2.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment